Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Questionnaire to Emotion Survey #4

Merged
merged 8 commits into from
Jan 23, 2024

Conversation

carolinentran
Copy link
Contributor

@carolinentran carolinentran commented Jan 16, 2024

modified social support questionnaire with emotion survey

Task 4: Add a questionnaire

♻️ Current situation & Problem

The application currently has a Social Support Questionnaire. To make it more relevant to the Behavior Project, I added different questions regarding emotions, feeling of accomplishments, and actual goals completed. The questionnaire also includes conditional questions (depending on the user's answers on their emotions and challenges).

⚙️ Release Notes

  • User is reminded to take daily survey
  • Questionnaire opens as a screen/modal
  • Questionnaire allows user to close it and come back at a later time
  • Questionnaire entry button is disabled if user already filled out the daily form

📚 Documentation

✅ Testing

  • While testing my modifications, I found that the xcode simulator was not loading my changes. The modified questionnaire does show up when running the iPhone simulator though so this would be the best way to test the changes made.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Screenshots of Questionnaire:

simulator_screenshot_1FE943DA-60EB-46B4-85BE-2AAE053CA283
simulator_screenshot_F6F642D1-8D69-4D6F-AF38-4DBE25DE29CB

modified social support questionnaire with emotion survey
added comments for replacement of questionnaire content
There was a path error with how I added the new json file. As a quick fix, I replaced the old questionnaire json with the new json. I'd like to discuss this more with the teaching staff for future improvements.
removing this since I modified the social support json directly
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eca33c2) 39.35% compared to head (5a29ce2) 39.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   39.35%   39.53%   +0.18%     
==========================================
  Files          31       31              
  Lines        1009     1012       +3     
==========================================
+ Hits          397      400       +3     
  Misses        612      612              
Files Coverage Δ
Behavior/Schedule/BehaviorScheduler.swift 83.88% <100.00%> (+1.73%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eca33c2...5a29ce2. Read the comment docs.

Copy link
Member

@vishnuravi vishnuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carolinentran,

Great job on this task! There are a couple of small things that could be improved:

  1. The questionnaire file is still called SocialSupportQuestionnaire.json. I would change this to match your survey, e.g. EmotionSurvey.json and then update the references in your code.
  2. The title on each question view is still Social Support. I would update this to be Emotion Survey.

Nice job incorporating some navigation logic into the survey JSON! It seems like there is an issue with the enableWhen statements for a couple of the questions. Although this is not required for the assignment, I'm happy to go over this and help you fix the bug.

Great work overall!

I changed the title of the questionnaire and other labeling in the json file. I also renamed the json file itself to better match the questionnaire.
Copy link
Member

@vishnuravi vishnuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @carolinentran!

@carolinentran carolinentran merged commit 9180af0 into main Jan 23, 2024
7 checks passed
@carolinentran carolinentran deleted the feature/task4-addAQuestionnaire branch January 23, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants