Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sleep and Workout Data #32

Closed
wants to merge 2 commits into from
Closed

Conversation

mjoerke
Copy link
Collaborator

@mjoerke mjoerke commented Feb 27, 2024

Adding Sleep and Workout Data

♻️ Current situation & Problem

The current version of the app does not upload sleep data or workout data, both of which are important data sources to include for physical activity behavior change. This PR adds support to query HealthKit for HKCategoryType(.sleepAnalysis) and HKWorkoutType entries and upload them appropriately to our Firestore database.

⚙️ Release Notes

  • Updated the query in PrismaAppDelegate.swift and added additional functionality in PrismaStandard+HealthKit.swift for processing upload paths, which previously only support HKQuantityType objects.

📚 Documentation

N/A

✅ Testing

N/A

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 24.28571% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 35.97%. Comparing base (b4e57f9) to head (b549eed).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   37.46%   35.97%   -1.48%     
==========================================
  Files          40       40              
  Lines        1383     1418      +35     
==========================================
- Hits          518      510       -8     
- Misses        865      908      +43     
Files Coverage Δ
Prisma/PrismaDelegate.swift 93.11% <100.00%> (+1.33%) ⬆️
Prisma/Standard/PrismaStandard+Extension.swift 0.00% <0.00%> (ø)
Prisma/Standard/PrismaStandard+HealthKit.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e57f9...b549eed. Read the comment docs.

@mjoerke mjoerke closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant