Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify button styles throughout application #91

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

philippzagar
Copy link
Contributor

Unify button styles throughout the application

♻️ Current situation & Problem

Currently, we use a variety of of button styles throughout the application, especially regarding scrolling behavior.

⚙️ Release Notes

  • Unify button styles throughout the application, especially in regards to scrollable behavior.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Apr 2, 2024
@philippzagar philippzagar self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 54.01070% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 50.13%. Comparing base (a859470) to head (4e2c47e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   49.79%   50.13%   +0.34%     
==========================================
  Files          51       51              
  Lines        3083     3156      +73     
==========================================
+ Hits         1535     1582      +47     
- Misses       1548     1574      +26     
Files Coverage Δ
Intake/Helper/Binding+Negate.swift 100.00% <ø> (ø)
Intake/Helper/Bundle+Image.swift 0.00% <ø> (ø)
Intake/Helper/CodableArray+RawRepresentable.swift 0.00% <ø> (ø)
Intake/Helper/ViewElements.swift 72.10% <ø> (ø)
Intake/PatientView/PatientInfo.swift 86.43% <100.00%> (+2.73%) ⬆️
Intake/ExportView/ScrollablePDF.swift 69.59% <95.24%> (+1.17%) ⬆️
Intake/AllergyView/AllergyRecords.swift 64.77% <90.00%> (+1.53%) ⬆️
Intake/MedicalHistoryView/MedicalHistoryView.swift 90.55% <88.24%> (+0.45%) ⬆️
Intake/SurgeryView/SurgeryView.swift 85.54% <89.48%> (+0.54%) ⬆️
Intake/PatientView/EditPatient.swift 0.00% <0.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a859470...4e2c47e. Read the comment docs.

@philippzagar philippzagar enabled auto-merge (squash) April 2, 2024 05:53
Copy link
Contributor

@kcallon kcallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change thank you!!

@philippzagar philippzagar merged commit dd1dedd into main Apr 2, 2024
7 checks passed
@philippzagar philippzagar deleted the feat/unify-button-style branch April 2, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants