Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdf finalize #69

Merged
merged 27 commits into from
Mar 13, 2024
Merged

Pdf finalize #69

merged 27 commits into from
Mar 13, 2024

Conversation

ninaboord
Copy link
Contributor

@ninaboord ninaboord commented Mar 11, 2024

PDF minor updates

♻️ Current situation & Problem

The PDF is now in the navigation stack!

Bugs squashed:

  • Error with view not displaying environment variables
  • Error with PDF not expanding with view size

PDF is now working and rendering all of the data! Formatting updates to come.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 10.25%. Comparing base (352cad1) to head (ccf127f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   10.35%   10.25%   -0.09%     
==========================================
  Files          62       62              
  Lines        3509     3513       +4     
==========================================
- Hits          363      360       -3     
- Misses       3146     3153       +7     
Files Coverage Δ
Intake/Elements.swift 25.59% <ø> (ø)
Intake/Home.swift 91.92% <100.00%> (-0.23%) ⬇️
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)
Intake/Export/ExportView.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352cad1...ccf127f. Read the comment docs.

Copy link
Contributor

@zoyagarg zoyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to fix merge conflicts I can help

@ninaboord ninaboord merged commit 5c68ae9 into main Mar 13, 2024
7 checks passed
@ninaboord ninaboord deleted the pdf-finalize branch March 13, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants