Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Updates to Medications including Scrollable PDF #66

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

kcallon
Copy link
Contributor

@kcallon kcallon commented Mar 11, 2024

Minor Updates to Medications including Scrollable PDF

♻️ Current situation & Problem

The medications final view was missing the frequency of the medications. Additionally, some patients didn't have any medications assigned to them, so I added some options.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@kcallon kcallon requested a review from zoyagarg March 11, 2024 01:59
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 10.85%. Comparing base (a8de6e9) to head (554e44d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   10.96%   10.85%   -0.10%     
==========================================
  Files          60       60              
  Lines        3333     3365      +32     
==========================================
  Hits          365      365              
- Misses       2968     3000      +32     
Files Coverage Δ
Intake/Medication View/MedicationContentView.swift 0.00% <0.00%> (ø)
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)
...ke/Medication View/IntakeMedicationViewModel.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8de6e9...554e44d. Read the comment docs.

Copy link
Contributor

@zoyagarg zoyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo lala!!!

@kcallon kcallon merged commit 081ea98 into main Mar 11, 2024
7 checks passed
@kcallon kcallon deleted the updating_medications branch March 11, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants