Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable pdf changes #61

Merged
merged 21 commits into from
Mar 10, 2024
Merged

Scrollable pdf changes #61

merged 21 commits into from
Mar 10, 2024

Conversation

apgupta3303
Copy link
Contributor

Adding Patient Data and fixing Reaction Screen*

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

  • The scrollable PDF will now be updated with the patient name instead of hard coded name I previously had.
  • The reaction view now lets you just add and delete reactions within the view. This made more sense because otherwise they would have to go back like 3 times and it would be more complicated for them to change a reaction if they saw something they did not like

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0.95238% with 104 lines in your changes are missing coverage. Please review.

Project coverage is 12.60%. Comparing base (e31d041) to head (59544fe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   12.88%   12.60%   -0.27%     
==========================================
  Files          58       58              
  Lines        2943     3000      +57     
==========================================
- Hits          379      378       -1     
- Misses       2564     2622      +58     
Files Coverage Δ
Intake/Intake.swift 100.00% <100.00%> (ø)
Intake/Surgery/SurgeryView.swift 0.00% <0.00%> (ø)
Intake/Allergy Records/ReactionPDF.swift 0.00% <0.00%> (ø)
Intake/ChiefComplaint/LLMInteraction.swift 35.85% <0.00%> (-1.09%) ⬇️
Intake/SocialHistory/SmokingHistory.swift 0.00% <0.00%> (ø)
Intake/Allergy Records/AddAllergy.swift 0.00% <0.00%> (ø)
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31d041...59544fe. Read the comment docs.

Copy link
Contributor

@zoyagarg zoyagarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did someone say ... lebron can also CODE!

@apgupta3303 apgupta3303 merged commit 6769f52 into main Mar 10, 2024
7 checks passed
@apgupta3303 apgupta3303 deleted the AddingScrollablePDF branch March 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants