-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assignment 1, Task 2 - Update onboarding flow #6
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
- Coverage 40.37% 40.03% -0.34%
==========================================
Files 30 30
Lines 939 947 +8
==========================================
Hits 379 379
- Misses 560 568 +8
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nriedman ,
Thank you for the PR and the improvements. It's a great first version that only needs some more very minor changes!
Thank you for using the PR template! Please also add a more descriptive and clear title focusing on the added functionality rather than the assignment task. Also, fill out the Documentation
and Testing
part of the PR template, it's completely fine to state that you didn't do anything in that aspect within your PR.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you updated the branch to the main branch, you have updated the PR description, and addressed some of the in-line comments and I am happy to approve the PR to get it merged 🚀
@nriedman Please merge the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks the last changes @nriedman, the PR is now ready to merge! 🚀
Customized onboarding flow with updated text and symbols
♻️ Current situation & Problem
The onboarding pipeline had default text and symbols from the Spezi Template.
⚙️ Release Notes
Updated the first and second screens to include Intake specific text and symbols. The first onboarding screen has an introduction to the Intake app, and the second describes the user journey through the app, listing the key components of the medical intake form the app will help them complete. I made sure all the strings were localized.
📚 Documentation
I did not make significant changes to the back-end code. I only changed text and symbols in the welcome and interesting_modules views.
✅ Testing
For this request, I will be relying on the default tests that we run every time we merge to main.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: