Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment 1, Task 2 - Update onboarding flow #6

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Conversation

nriedman
Copy link
Contributor

@nriedman nriedman commented Jan 16, 2024

Customized onboarding flow with updated text and symbols

♻️ Current situation & Problem

The onboarding pipeline had default text and symbols from the Spezi Template.

⚙️ Release Notes

Updated the first and second screens to include Intake specific text and symbols. The first onboarding screen has an introduction to the Intake app, and the second describes the user journey through the app, listing the key components of the medical intake form the app will help them complete. I made sure all the strings were localized.

📚 Documentation

I did not make significant changes to the back-end code. I only changed text and symbols in the welcome and interesting_modules views.

✅ Testing

For this request, I will be relying on the default tests that we run every time we merge to main.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@nriedman nriedman changed the title Updated text and symbols for onboarding pipeline. Assignment 1, Task 2 Jan 16, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (725e22f) 40.37% compared to head (ff1bd94) 40.03%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   40.37%   40.03%   -0.34%     
==========================================
  Files          30       30              
  Lines         939      947       +8     
==========================================
  Hits          379      379              
- Misses        560      568       +8     
Files Coverage Δ
Intake/Onboarding/Welcome.swift 94.60% <100.00%> (ø)
Intake/Onboarding/InterestingModules.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725e22f...ff1bd94. Read the comment docs.

@PSchmiedmayer PSchmiedmayer removed their request for review January 17, 2024 00:32
@philippzagar philippzagar self-requested a review January 17, 2024 04:47
Copy link
Contributor

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nriedman ,

Thank you for the PR and the improvements. It's a great first version that only needs some more very minor changes!

Thank you for using the PR template! Please also add a more descriptive and clear title focusing on the added functionality rather than the assignment task. Also, fill out the Documentation and Testing part of the PR template, it's completely fine to state that you didn't do anything in that aspect within your PR.

Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.

Please re-request a review once you updated the branch to the main branch, you have updated the PR description, and addressed some of the in-line comments and I am happy to approve the PR to get it merged 🚀

Intake/Onboarding/InterestingModules.swift Show resolved Hide resolved
Intake/Onboarding/InterestingModules.swift Outdated Show resolved Hide resolved
Intake/Onboarding/InterestingModules.swift Outdated Show resolved Hide resolved
Intake/Onboarding/InterestingModules.swift Outdated Show resolved Hide resolved
Intake/Onboarding/Welcome.swift Show resolved Hide resolved
@philippzagar philippzagar added the enhancement New feature or request label Jan 18, 2024
@nriedman nriedman changed the title Assignment 1, Task 2 Assignment 1, Task 2 - Update onboarding flow Jan 23, 2024
@nriedman nriedman enabled auto-merge (squash) January 23, 2024 18:03
@philippzagar
Copy link
Contributor

@nriedman Please merge the main branch into your feature branch and resolve the merge conflicts in the Localizable file.

Copy link
Contributor

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the last changes @nriedman, the PR is now ready to merge! 🚀

@nriedman nriedman merged commit fe31b35 into main Jan 23, 2024
7 checks passed
@nriedman nriedman deleted the asign1/task2 branch January 23, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants