Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scrollable pdf #55

Merged
merged 12 commits into from
Mar 8, 2024
Merged

Adding scrollable pdf #55

merged 12 commits into from
Mar 8, 2024

Conversation

apgupta3303
Copy link
Contributor

@apgupta3303 apgupta3303 commented Mar 6, 2024

Scrollable pdf

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

*Gives the user a summary of the form by making a scrollable view at the end of the app.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@nriedman nriedman self-requested a review March 8, 2024 01:52
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 3.33333% with 203 lines in your changes are missing coverage. Please review.

Project coverage is 12.65%. Comparing base (52b4aa6) to head (fca7f0e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   13.08%   12.65%   -0.43%     
==========================================
  Files          55       58       +3     
  Lines        2845     3022     +177     
==========================================
+ Hits          372      382      +10     
- Misses       2473     2640     +167     
Files Coverage Δ
Intake/Home.swift 90.81% <100.00%> (+0.22%) ⬆️
Intake/Intake.swift 100.00% <100.00%> (ø)
Intake/Medical History/MedicalHistoryView.swift 0.00% <0.00%> (ø)
Intake/Allergy Records/AllergyRecords.swift 0.00% <0.00%> (ø)
Intake/Elements.swift 38.47% <0.00%> (-3.20%) ⬇️
Intake/EditPatient.swift 0.00% <0.00%> (ø)
Intake/Allergy Records/ReactionPDF.swift 0.00% <0.00%> (ø)
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b4aa6...fca7f0e. Read the comment docs.

Copy link
Contributor

@nriedman nriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nriedman nriedman merged commit 56d1e78 into main Mar 8, 2024
7 checks passed
@nriedman nriedman deleted the AddingScrollablePDF branch March 8, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants