Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task1 #3

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Task1 #3

merged 9 commits into from
Jan 23, 2024

Conversation

apgupta3303
Copy link
Contributor

@apgupta3303 apgupta3303 commented Jan 16, 2024

Assign1/Task1*

♻️ Current situation & Problem

  • Currently our app icon does not properly reflect the functionality of our app
  • The accent color needs to be changed for visual appeal
  • Our contacts page does not provide the contact information for Professor Aalami. *

⚙️ Release Notes

  • Added new app icon picture and profile picture to assets
  • Changed accent color in assets
  • Changed contact information for Professor Aalami

📚 Documentation

  • I did not change any documentation

✅ Testing

  • I did not perform any tests

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3b63416) 40.30% compared to head (851d12c) 40.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   40.30%   40.37%   +0.07%     
==========================================
  Files          30       30              
  Lines         938      939       +1     
==========================================
+ Hits          378      379       +1     
  Misses        560      560              
Files Coverage Δ
Intake/Contacts/Contacts.swift 70.00% <90.91%> (+0.62%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b63416...851d12c. Read the comment docs.

@apgupta3303 apgupta3303 reopened this Jan 16, 2024
Copy link
Member

@AdritRao AdritRao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apgupta3303, the code looks great 👍!

Can you please update your branch to be on the latest version of main?

Thanks!
Adrit

@apgupta3303 apgupta3303 enabled auto-merge (squash) January 22, 2024 22:24
@apgupta3303
Copy link
Contributor Author

@AdritRao Could you please review again?

Copy link
Member

@AdritRao AdritRao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @apgupta3303, thank you for merging the main branch into your feature branch. Because another update was made to main, can you please ensure that your branch is up to date with the main branch again. After that, feel free to merge your branch! Thank you! 🚀

@apgupta3303 apgupta3303 merged commit 725e22f into main Jan 23, 2024
6 checks passed
@apgupta3303 apgupta3303 deleted the task1 branch January 23, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants