Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
* add gitignore for nodemodules and .env * init sqlite database, init matchmodel, create CRUD routes * add difficultySelection component (radio buttons and submit button) * add npm uuid for generating userId * post insert diff * format typescript * git ignore dev instance * allowNull false userId * add matchedUser col
* add gitignore for nodemodules and .env * init sqlite database, init matchmodel, create CRUD routes * add difficultySelection component (radio buttons and submit button) * add npm uuid for generating userId * post insert diff * format typescript * git ignore dev instance * allowNull false userId * install deps * Set up matching and navigation to empty room * Prepare room and clean up code * Set up matching dialog and leave room option * Clean up Co-authored-by: Wayne Tan <[email protected]>
* init * Add eslint and prettier and format all files * Add missing file from prev commit * Change prettier rule to use double quotes for string * For testing * Trigger ci only on push to main and all PRs * Move ci.yml to /workflows * For testing * Fix identifier syntax * Run CI on PR and fix typo * Resolve merge conflicts * Fix formatting and disable prop-types rules * Fix formatting and add trailing commas to all
* FR 1.2 Checks unique user * FR1.3 and NFR1 Add login and password salt hashing
* add delete user without checking jwt * remove jwt from controller * add jwt check * correct error message * add condition to get error in the res Co-authored-by: tribecar.tianyong <[email protected]>
* add api to get one time link and reset password * debug compare password * add email field while signing up and send email when forget password * update base on the comment given * remove unnecessarily api * update error return Co-authored-by: tribecar.tianyong <[email protected]>
* add mongoose model, schema, match-orm and match-controller * cleanup * change username to userId * findOneAndDelete * repository renaming * createOneMatchModel and deleteOneMatchModel
* add simple navbar * change signup page * change login page and minor change in sign up page * add reset password page * add forget password page * change difficulty selection * update room * add menu and refactor file * style navbar * style reset password page * style forget-password page and signup page * style login page * style room page and home page * resolve lint error * minor change in login page * use useState to update if the menu is opened * abstract some styling and update room page * refactor file
* Set up collaboration service * Fix collab-service * Set up collaboration code editor * Preserve whitespace and add postman collection * Set up CRUD api for collaboration service * Add shared code editor * Resolve merge conflicts * Resolve merge conflicts
* add logout and direct to other page * add simple navbar * change signup page * change login page and minor change in sign up page * add reset password page * add forget password page * change difficulty selection * update room * add menu and refactor file * style navbar * style reset password page * style forget-password page and signup page * style login page * style room page and home page * resolve lint error * minor change in login page * logout and route to login * add logout * remove cookie check * resolve cookie problem Co-authored-by: tribecar.tianyong <[email protected]>
* add logout and direct to other page * add delete user without checking jwt * remove jwt from controller * add jwt check * correct error message * add condition to get error in the res * add simple navbar * change signup page * change login page and minor change in sign up page * add reset password page * add forget password page * change difficulty selection * update room * add menu and refactor file * style navbar * style reset password page * style forget-password page and signup page * style login page * style room page and home page * resolve lint error * minor change in login page * logout and route to login * add logout * remove cookie check * resolve cookie problem * add delete api(not done) * integrate delete user api * extract cookie out Co-authored-by: tribecar.tianyong <[email protected]>
* add api to get one time link and reset password * debug compare password * add email field while signing up and send email when forget password * update base on the comment given * remove unnecessarily api * update error return * add simple navbar * change signup page * change login page and minor change in sign up page * add reset password page * add forget password page * change difficulty selection * update room * add menu and refactor file * style navbar * style reset password page * style forget-password page and signup page * style login page * style room page and home page * resolve lint error * minor change in login page * use useState to update if the menu is opened * abstract some styling and update room page * integrate forget password api into front end * integrate reset password api * integrate reset link into navbar Co-authored-by: tribecar.tianyong <[email protected]>
* init question service * create ques * get one question randomly * render question * npm run lint:fix not working * sync question between 2 users * remove unused * remove question title * socket to send quesId, frontend fetch question by id
* working voice chat * update icon button Co-authored-by: TianYong-Goh <[email protected]>
* update design for room page * update login page * refactor signup page * refactor signup error * refactor login page * refactor forget password * update button text * extract alert and dialog * add protected route * resolve refresh logout problem * update homepage button styling * redirect to home page after login and cookies still apply (hide login page) * remove redux and debug nevigation * remove redux
* Separate socket objs for matching and collab services * Handle user lost connection in home and room page * format and remove print statements * Fix prettier formats * Make sure state is updated before sending update collab api * Resolve merge conflicts * Clean up
* Update with npm i and remove userinfo api * Add question service to the concurrent run
* init * APIs for create one history, get one history by id, get histories by userId * bug fixed for find histories by userId * update history return updated history, only update history answer * add postman collection
* sort history by updatedAt desc * enum easy, medium, hard * getting a ques by diff: diff must be either easy, medium or hard * add postman collection for question service
* update the routing to check caching every access of link * disallow match when token expired Co-authored-by: Ho Pin Xian <[email protected]>
* Update history model * Fix lint
* add list history ui * add history page * link to backend(not test) * change api * lik history to frontend * styling history homepage * update path and solve socket unmatch problem * change path * update path
* add redis to question service * remove change in frontend * remove debug console * Update app yaml and add JSON parse for redis Co-authored-by: HoPinXian <[email protected]>
* Fix jumping cursors * Wrap stop audio in try catch * Support multiple cursors * adding fix height to the question text field * Package-lock.json updates Co-authored-by: TianYong-Goh <[email protected]>
* Testing for communication service * Testing for collaboration service
* Working ver * Use yjs for crdt
* improve ui and resolve newline removed problem * fix space trim while display * include username in history room page * fixing showing answer overflow and not wrap * add overflow scrollbar for question view
* add test dependencies and draft (not tested) * add back removed package-lock.json file * add create user api test * add delete user test * add login test * add forget password test and minor update of other test * add reset password test
* init mocha test * create ques: unit test * init mocha for history and matching * remove sqlite and sequelize from package.json * add unit tests for history-service and matching-service, post APIs to return data * bug redis create client undefined * add matching api test * add socket test * add cross-env for question svc * add cross env for history svc * add cross env for matching svc
* change reset user password to be a put api * update colour * Update package-lock.json * remove console.log for qn svc Co-authored-by: olivia johansen <[email protected]> Co-authored-by: Wayne Tan <[email protected]>
* Update readme and env.sample * Add report * remove report * Add updated readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @tanwayne890 @TianYong-Goh @hopinxian @oliviajohansen