Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix incorrect wheels name on publish #587

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

Fixes #586, which was broken when we moved pyproject.toml in #546.

Running maturin build from the root dir tries to build the workspace project, creating an invalid wheel name. This PR updates the ci job and the just build command to run maturin from inside /hugr-py/.

Maturin is still configured as a build tool in the workspace so that maturin develop works everywhere. In that case we don't care about the project name.

@aborgna-q aborgna-q requested a review from a team as a code owner September 5, 2024 11:04
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@aborgna-q
Copy link
Collaborator Author

Manually run workflow:

📦 Built wheel for CPython 3.10 to dist/tket2-0.3.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl

https://github.com/CQCL/tket2/actions/runs/10719118770/job/29722515638#step:4:570
(that is, the wheel name got fixed)

I will manually re-run the job for release 0.3.0 once this is merged

@aborgna-q aborgna-q added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit e3f9da1 Sep 5, 2024
16 of 28 checks passed
@aborgna-q aborgna-q deleted the ab/fix-wheels-name branch September 5, 2024 11:09
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
Fixes the fix from #587.

I edited the workflow to run in the PR, so we can test it works (without
an api key)

Closes #586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Wheels publish job failed due to project name
2 participants