feat(tket2-hseries): cli extension dumping #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 82.66% 82.45% -0.22%
==========================================
Files 46 47 +1
Lines 6496 6513 +17
Branches 6496 6513 +17
==========================================
Hits 5370 5370
- Misses 765 782 +17
Partials 361 361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BREAKING CHANGE: quantum extension renamed from "quantum.tket2" to "tket2.quantum"
|
Don't forget to add the angles extension too |
|
unpushed commit 😅 |
ss2165
changed the title
ss2165
changed the title
doug-q
reviewed
Sep 9, 2024
| cli = ["dep:clap", "dep:hugr-cli", "dep:clap-verbosity-flag", "dep:clio"] | ||
|
|
||
| [[bin]] | ||
| name = "tket2-hseries" |
There was a problem hiding this comment.
To extend the hugr cli this should be called something prefixed with hugr-
There was a problem hiding this comment.
I'm not sure this naturally extends the hugr cli, I think its fine stand alone for now. It's main use is within the repo anyway (using the justfile)
tket2-hseries/Cargo.toml
Outdated
| @@ -24,6 +32,10 @@ strum.workspace = true | |||
| strum_macros.workspace = true | |||
| thiserror.workspace = true | |||
| itertools.workspace = true | |||
| clap = { workspace = true, optional = true} | |||
| hugr-cli = { version = "*", optional = true } | |||
There was a problem hiding this comment.
I think these versions need to be fixed
tket2-hseries/src/cli.rs
Outdated
| #[derive(Parser, Debug)] | ||
| #[clap(version = "1.0", long_about = None)] | ||
| #[clap(about = "HUGR CLI tools.")] | ||
| #[group(id = "hugr")] |
There was a problem hiding this comment.
Is this right? also I don't think version is right?
Merged
doug-q
approved these changes
Sep 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
## 🤖 New release * `tket2`: 0.2.0 -> 0.3.0 * `tket2-hseries`: 0.2.0 -> 0.3.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.3.0](tket2-v0.2.0...tket2-v0.3.0) - 2024-09-09 ### Bug Fixes - extension ops checking against incorrect name ([#593](#593)) - [**breaking**] remove TryFrom for extension ops use `cast` ([#592](#592)) - don't load angle extensions on to quantum ([#597](#597)) ### New Features - [**breaking**] move angle types + and ops to new "tket2.angle" extension ([#591](#591)) - dataflow builder methods for angle ops ([#596](#596)) - lowering tk2ops -> hseriesops ([#579](#579)) </blockquote> ## `tket2-hseries` <blockquote> ## [0.3.0](tket2-hseries-v0.2.0...tket2-hseries-v0.3.0) - 2024-09-09 ### Bug Fixes - extension ops checking against incorrect name ([#593](#593)) - [**breaking**] remove TryFrom for extension ops use `cast` ([#592](#592)) ### New Features - lowering tk2ops -> hseriesops ([#579](#579)) - *(tket2-hseries)* cli extension dumping ([#584](#584)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.0](tket2-py-v0.3.0...tket2-py-v0.4.0) (2024-10-01) ### ⚠ BREAKING CHANGES * Made all errors `non_exhaustive`, and renamed some fields for clarity. * "tket2.angle" extension replaced with "tket2.rotation" extension with rotation type and simplified set of operations. * TryFrom implementations for extension op structs removed, use `cast` ### Features * `BadgerOptimiser.load_precompiled`, `BadgerOptimiser.compile_eccs` and `passes.badger_pass` now take an optional `cost_fn` parameter to specify the cost function to minimise. Supported values are `'cx'` (default behaviour) and `'rz'`. ([83ebfcb](83ebfcb)) * simplify angle extension in to a half turns rotation type ([#611](#611)) ([0723937](0723937)) * Support encoding float and sympy ops ([#618](#618)) ([74dcbf7](74dcbf7)) * **tket2-hseries:** cli extension dumping ([#584](#584)) ([abf292f](abf292f)) ### Bug Fixes * remove TryFrom for extension ops use `cast` ([#592](#592)) ([5ca29af](5ca29af)) * Support hugr packages, fix the notebooks ([#622](#622)) ([1cf9dcb](1cf9dcb)) ### Documentation * Add tket2-py module docstring ([#539](#539)) ([8ef7a57](8ef7a57)) ### Miscellaneous Chores * Replace thiserror with derive_more 1.0 ([#624](#624)) ([2250ce7](2250ce7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]> Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #556