feat: Add StaticSizeCircuit #554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmondada
force-pushed
the
feat/StaticSizeCircuit
branch
from
8a46ea8
to
dd083ee
Compare
|
I'm reworking the definition of StaticSizeCirc, I'll let you know when this is ready to review! |
lmondada
force-pushed
the
feat/StaticSizeCircuit
branch
from
90f270f
to
58b5d31
Compare
lmondada
force-pushed
the
feat/StaticSizeCircuit
branch
from
58b5d31
to
67d6d90
Compare
aborgna-q
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Could this go inside portmatching/? Or do we expect it to be used by anything else?
| /// A circuit with a fixed number of qubits numbered from 0 to `num_qubits - 1`. | ||
| #[derive(Clone, Default)] | ||
| pub struct StaticSizeCircuit { | ||
| /// All quantum operations on qubits. |
There was a problem hiding this comment.
Clarify a bit what's each vector about.
Suggested change
| /// All quantum operations on qubits. | |
| /// All quantum operations on each qubit. |
| fn exists(&self, loc: OpLocation) -> bool { | ||
| self.qubit_ops | ||
| .get(loc.qubit.0) | ||
| .map_or(false, |ops| ops.get(loc.op_idx).is_some()) |
There was a problem hiding this comment.
Suggested change
| .map_or(false, |ops| ops.get(loc.op_idx).is_some()) | |
| .map_or(false, |ops| loc.op_idx < ops.len()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am starting work on an MVP for Badger v2. This will not be merged into main for a while, as
i) the performance of
portmatchingis currently significantly worse than the last versionii) the set of operations and types of circuits that is supported is very limited.
Description of
StaticSizeCircuitThis simple
structcaptures circuits with no classical data (and hence also no parametric angle). This will be the starting point to build patterns and compute updateable hashes.This could in principle be extended in the future to handle more cases, but neither Agustin nor I are convinced that this should ever find its way to
main... Handling more general cases will require work into fast and updateable hashing.