feat!: Replace GATs with impl Iterator returns (RPITIT) on HugrView
#1660
+192
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1660 +/- ##
==========================================
+ Coverage 85.51% 85.55% +0.03%
==========================================
Files 136 136
Lines 25264 25325 +61
Branches 22176 22237 +61
==========================================
+ Hits 21605 21667 +62
+ Misses 2455 2453 -2
- Partials 1204 1205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
aborgna-q
changed the title
impl Iterator returns (RPITIT) on HugrViewimpl Iterator returns (RPITIT) on HugrView
ss2165
reviewed
Nov 15, 2024
| @@ -40,36 +37,6 @@ use itertools::Either; | |||
| /// A trait for inspecting HUGRs. | |||
| /// For end users we intend this to be superseded by region-specific APIs. | |||
| pub trait HugrView: HugrInternals { | |||
| /// An Iterator over the nodes in a Hugr(View) | |||
| .nodes() | ||
| .with_context(self) | ||
| .map_with_context(|n, &wrapper| HugrNodeRef::from_node(n, wrapper.hugr)) | ||
| Box::new( |
There was a problem hiding this comment.
I'm surprised this is not tested
| @@ -251,6 +223,16 @@ pub struct SiblingMut<'g, Root = Node> { | |||
| _phantom: std::marker::PhantomData<Root>, | |||
| } | |||
|
|
|||
| impl<'g, Root> SiblingMut<'g, Root> { | |||
| &self, | ||
| node: Node, | ||
| port: impl Into<Port>, | ||
| ) -> impl Iterator<Item = (Node, Port)> + Clone { | ||
| // Need to filter only to links inside the sibling graph |
There was a problem hiding this comment.
this comment now works better at the bottom of the function
| } | ||
|
|
||
| fn node_connections(&self, node: Node, other: Node) -> Self::NodeConnections<'_> { | ||
| fn node_connections(&self, node: Node, other: Node) -> impl Iterator<Item = [Port; 2]> + Clone { | ||
| // Need to filter only to connections inside the sibling graph | ||
| SiblingGraph::<'_, Node>::new_unchecked(self.hugr, self.root) |
There was a problem hiding this comment.
would some of these methods also benefit from the portgraph based implementation seen in linked_ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify the update to the next portgraph release (which also moved to RPITIT), avoiding the need to use boxes around iterators to be able to name them.
context-iteratorsBREAKING CHANGE: Removed
HugrViewassociated iterator types, replaced withimpl Iteratorreturns.