Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lists and extension sets with splicing #1657

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zrho
Copy link
Contributor

@zrho zrho commented Nov 14, 2024

Closes #1609.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 73.42995% with 55 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (e63878f) to head (9a820cb).

Files with missing lines Patch % Lines
hugr-core/src/import.rs 59.67% 16 Missing and 9 partials ⚠️
hugr-core/src/export.rs 78.33% 13 Missing ⚠️
hugr-model/src/v0/text/print.rs 70.96% 2 Missing and 7 partials ⚠️
hugr-model/src/v0/text/parse.rs 68.75% 2 Missing and 3 partials ⚠️
hugr-model/src/v0/binary/read.rs 85.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   85.51%   85.46%   -0.06%     
==========================================
  Files         136      136              
  Lines       25264    25285      +21     
  Branches    22176    22197      +21     
==========================================
+ Hits        21605    21610       +5     
- Misses       2455     2466      +11     
- Partials     1204     1209       +5     
Flag Coverage Δ
python 92.42% <ø> (ø)
rust 84.49% <73.42%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugrbot
Copy link
Collaborator

hugrbot commented Nov 14, 2024

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

--- failure enum_struct_variant_field_added: pub enum struct variant field added ---

Description:
An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant.
      ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/enum_struct_variant_field_added.ron

Failed in:
field items of variant Term::ExtSet in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-model/src/v0/mod.rs:607

--- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed ---

Description:
A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/enum_struct_variant_field_missing.ron

Failed in:
field tail of variant Term::List, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-model/src/v0/mod.rs:578
field extensions of variant Term::ExtSet, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-model/src/v0/mod.rs:617
field rest of variant Term::ExtSet, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-model/src/v0/mod.rs:619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension sets and lists with variables in hugr-model
2 participants