Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix unsoundness tests #1643

Merged
merged 3 commits into from
Nov 8, 2024
Merged

chore: Fix unsoundness tests #1643

merged 3 commits into from
Nov 8, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Nov 7, 2024

A test was using the filesystem to check insta snapshots. This is not supported by miri.

drive-by: Fix lint warning
drive-by: Don't send a slack notification when running the miri checks manually on an arbitrary commit.

CI run:
https://github.com/CQCL/hugr/actions/runs/11726988593

@aborgna-q aborgna-q requested a review from a team as a code owner November 7, 2024 15:39
@aborgna-q aborgna-q requested a review from zrho November 7, 2024 15:39
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.79%. Comparing base (3a297d5) to head (9a40e90).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   85.79%   85.79%   -0.01%     
==========================================
  Files         136      136              
  Lines       25180    25180              
  Branches    22092    22092              
==========================================
- Hits        21604    21603       -1     
- Misses       2426     2427       +1     
  Partials     1150     1150              
Flag Coverage Δ
python 92.42% <ø> (ø)
rust 84.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 5562c91 Nov 8, 2024
25 checks passed
@aborgna-q aborgna-q deleted the ab/fix-miri branch November 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants