fix: Update number of ports for PartialOps, and sanitize orderd edges #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
commented
Nov 5, 2024
| # https://github.com/CQCL/hugr/issues/1625 | ||
| def test_dfg_unpack() -> None: | ||
| dfg = Dfg(tys.Tuple(tys.Bool, tys.Bool)) | ||
| bool1, _unused_bool2 = dfg.add_op(ops.UnpackTuple(), *dfg.inputs()) |
There was a problem hiding this comment.
Notice that we don't use the node's 2nd output.
ss2165
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of ports in a
PartialOpdataflow node didn't get updated after connecting it.We didn't see any problem with this because by default the number of output ports is grown when connecting new outputs, so the count ended up being correct.
#1625 found a bug where an
UnpackTupledidn't connect its last output, so the serialization though the node had less output ports than it should have, and connected the order edge at an incorrect offset.As part of this change I added various checks for the order edge index. We use a special
-1offset to identify them, so we should panic when that is seen on invalid places.Hugr::has_linkmethodCloses #1625