Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: to/from json for extension/package #1575

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: to/from json for extension/package #1575

merged 1 commit into from
Oct 11, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Oct 11, 2024

Closes #1523

@ss2165 ss2165 requested a review from aborgna-q October 11, 2024 14:44
@ss2165 ss2165 requested a review from a team as a code owner October 11, 2024 14:44
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (f74dbf3) to head (45f9df5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1575      +/-   ##
==========================================
+ Coverage   85.69%   85.70%   +0.01%     
==========================================
  Files         135      135              
  Lines       24563    24574      +11     
  Branches    21512    21512              
==========================================
+ Hits        21050    21062      +12     
+ Misses       2415     2414       -1     
  Partials     1098     1098              
Flag Coverage Δ
python 92.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit f8bf61a Oct 11, 2024
20 checks passed
@ss2165 ss2165 deleted the ss/ext-from-json branch October 11, 2024 15:00
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.9.0](hugr-py-v0.8.1...hugr-py-v0.9.0)
(2024-10-14)


### ⚠ BREAKING CHANGES

* `Package` moved to new `hugr.package` module
* The `length` op in the std `collections` extensions now also returns
the list.

### Features

* `instantiate` method for `OpDef`
([#1576](#1576))
([36548ab](36548ab)),
closes [#1512](#1512)
* define wrappers around package that point to internals
([#1573](#1573))
([f74dbf3](f74dbf3))
* to/from json for extension/package
([#1575](#1575))
([f8bf61a](f8bf61a)),
closes [#1523](#1523)


### Bug Fixes

* Make list length op give back the list
([#1547](#1547))
([cf31698](cf31698))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a from_json to hugr.ext.Extension
2 participants