feat: FunctionBuilder::add_{in,out}put
#1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
==========================================
+ Coverage 85.71% 85.74% +0.03%
==========================================
Files 132 134 +2
Lines 24018 24623 +605
Branches 21018 21623 +605
==========================================
+ Hits 20588 21114 +526
- Misses 2366 2407 +41
- Partials 1064 1102 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 11, 2024
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
## 🤖 New release * `hugr`: 0.13.0 -> 0.13.1 (✓ API compatible changes) * `hugr-core`: 0.10.0 -> 0.13.1 (✓ API compatible changes) * `hugr-model`: 0.1.0 -> 0.13.1 (✓ API compatible changes) * `hugr-passes`: 0.8.2 -> 0.13.1 (✓ API compatible changes) * `hugr-cli`: 0.6.1 -> 0.13.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.13.1](hugr-v0.13.0...hugr-v0.13.1) - 2024-10-14 ### New Features - return replaced ops from lowering ([#1568](#1568)) - Make `BuildHandle::num_value_outputs` public ([#1560](#1560)) - `FunctionBuilder::add_{in,out}put` ([#1570](#1570)) - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) </blockquote> ## `hugr-core` <blockquote> ## [0.13.1](hugr-core-v0.10.0...hugr-core-v0.13.1) - 2024-10-14 ### New Features - Make `BuildHandle::num_value_outputs` public ([#1560](#1560)) - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) - `FunctionBuilder::add_{in,out}put` ([#1570](#1570)) </blockquote> ## `hugr-model` <blockquote> ## [0.13.1](hugr-model-v0.1.0...hugr-model-v0.13.1) - 2024-10-14 ### New Features - Binary serialisation format for hugr-model based on capnproto. ([#1557](#1557)) </blockquote> ## `hugr-passes` <blockquote> ## [0.13.1](hugr-passes-v0.8.2...hugr-passes-v0.13.1) - 2024-10-14 ### New Features - return replaced ops from lowering ([#1568](#1568)) </blockquote> ## `hugr-cli` <blockquote> ## 0.6.0 (2024-09-04) ### Features - [**breaking**] Allow registry specification in `run_dump` ([#1501](#1501)) - [**breaking**] Add `Package::validate` and return `ExtensionRegistry` in helpers. ([#1507](#1507)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]> Co-authored-by: Agustín Borgna <[email protected]> Co-authored-by: Alec Edgington <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1562.
It's a chunk of code fiddling with the hugr internals, but it is something specific to function definitions so I think it should be ok to have it under
FunctionBuilder.