Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use setup-uv action #1552

Merged
merged 1 commit into from
Oct 4, 2024
Merged

ci: Use setup-uv action #1552

merged 1 commit into from
Oct 4, 2024

Conversation

aborgna-q
Copy link
Collaborator

No description provided.

@aborgna-q aborgna-q requested a review from a team as a code owner October 4, 2024 08:58
@aborgna-q aborgna-q requested a review from acl-cqc October 4, 2024 08:58
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (cd74ba7) to head (f0ea623).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1552   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files         127      127           
  Lines       21740    21740           
  Branches    18740    18740           
=======================================
  Hits        19008    19008           
  Misses       1964     1964           
  Partials      768      768           
Flag Coverage Δ
python 92.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

uv-${{ runner.os }}
version: "0.4.18"
enable-cache: true
- name: Install Python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know how fast this is compared to the default setup python action, any reason to prefer it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say fast enough
image

They recommend doing it this way
https://github.com/astral-sh/setup-uv?tab=readme-ov-file#do-i-still-need-actionssetup-python-alongside-setup-uv

In the docs they mention this, but I don't think it makes much of a difference

Alternatively, the official GitHub setup-python action can be used. This can be faster, because GitHub caches the Python versions alongside the runner.

@aborgna-q aborgna-q added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit fc3efe5 Oct 4, 2024
20 checks passed
@aborgna-q aborgna-q deleted the ab/setup-uv branch October 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants