Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NonConvex error on SiblingSubgraph::from_nodes with multiports #1295

Merged
merged 2 commits into from
Jul 11, 2024

fix: NonConvex error with SiblingSubgraph on multiports

4f1f21a
Select commit
Loading
Failed to load commit list.
Merged

fix: NonConvex error on SiblingSubgraph::from_nodes with multiports #1295

fix: NonConvex error with SiblingSubgraph on multiports
4f1f21a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 11, 2024 in 0s

87.18% (-0.02%) compared to a70ca87, passed because coverage increased by -0.01% when compared to adjusted base (87.19%)

View this Pull Request on Codecov

87.18% (-0.02%) compared to a70ca87, passed because coverage increased by -0.01% when compared to adjusted base (87.19%)

Details

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.18%. Comparing base (a70ca87) to head (4f1f21a).

Files Patch % Lines
hugr-core/src/hugr/views/sibling_subgraph.rs 81.25% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   87.19%   87.18%   -0.02%     
==========================================
  Files         107      107              
  Lines       19513    19538      +25     
  Branches    17251    17276      +25     
==========================================
+ Hits        17015    17034      +19     
  Misses       1719     1719              
- Partials      779      785       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.