Skip to content

Commit

Permalink
ci: Fix unsoundness notification (#1641)
Browse files Browse the repository at this point in the history
Looks like `continue-on-error` on a step still doesn't trigger the
dependent jobs on error.

This PR ensures that the slack notification job runs when the miri
checks fail by adding an `if: always()` instead.
  • Loading branch information
aborgna-q authored Nov 7, 2024
1 parent f6c1572 commit 3a297d5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/unsoundness.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
miri:
name: "Miri"
runs-on: ubuntu-latest
continue-on-error: true
steps:
- uses: actions/checkout@v4
- name: Install Miri
Expand All @@ -44,11 +43,12 @@ jobs:
notify-slack:
uses: CQCL/hugrverse-actions/.github/workflows/slack-notifier.yml@main
needs: miri
if: ${{ needs.miri.result == 'failure' && ( github.event_name == 'workflow_dispatch' || github.event_name == 'push' ) }}
if: always() && needs.miri.result == 'failure'
with:
channel-id: 'C04SHCL4FKP'
slack-message: |
💥 The unsoundness check for `CQCL/hugr` failed. <https://github.com/CQCL/hugr/actions/runs/${{ github.run_id }}|Please investigate>.
💥 The unsoundness check for `CQCL/hugr` failed.
<https://github.com/CQCL/hugr/actions/runs/${{ github.run_id }}|Please investigate>.
# Rate-limit the message to once per day
timeout-minutes: 1440
# A repository variable used to store the last message timestamp.
Expand Down

0 comments on commit 3a297d5

Please sign in to comment.