Add Like activity and ability to send a like #254
Conversation
|
Also whats the story with c/sendlike |
|
This has been updated 👍 c/sendlike was a version of this change where I moved the activities stuff into utils in the same commits. I decided it was too big and split it, did a new branch because everything was mashed together in the commits. |
| def _create_actor_object(self, liker_handle): | ||
| return { | ||
| 'type': 'Person', | ||
| 'host': self._hostname, |
There was a problem hiding this comment.
As far as I can tell this isn't a valid actor, as it has no ID. Why are you sending actors like this and not like the existing services? Why not send an ID like {host}/@{handle} and parse it out at the other end?
There was a problem hiding this comment.
That's tru actually, changed 👍
|
|
||
| message LikeDetails { | ||
| int64 article_id = 1; | ||
| string liker_handle = 3; |
There was a problem hiding this comment.
handle only refers to the bit before the @ (ie. bob) in [email protected]. Is this intentional?
There was a problem hiding this comment.
It's all that's really needed since a like will only be sent by a local user, I attach the hostname inside the service.
Connects to #217
Kind of chunky PR but it's a lot of boilerplate and tests for the servicer mostly.