feat: Improve and update exercise state management

public/index.php

@@ -43,12 +43,8 @@ function getRedirection($redirect_uri)
 		case '/exercises/new':
 			createAnExercises();
 			break;
-		case (preg_match('/^\/exercises\/([0-9]+)\?exercise%5Bstatus%5D=(answering|closed)$/A', $_SERVER['REQUEST_URI'], $output_array) ? true : false):
-			if ($output_array[2] == 'answering') {
-				setExerciseAsAnswering($output_array[1]);
-			} elseif ($output_array[2] == 'closed') {
-				setExerciseAsClosed($output_array[1]);
-			}
+		case (preg_match('/^\/exercises\/([0-9]+)$/A', $redirect_uri, $output_array) ? true : false):
+			changeStateOfExercise($output_array[1]);
 			break;
 		default:
 			lost();

src/controllers/exercise_controller.php

@@ -13,19 +13,37 @@ function createExercise()
 	header('Location: /exercises/' . $exercise->getId() . '/fields');
 }
 
-function setExerciseAsAnswering(int $id)
+function changeStateOfExercise(int $id)
 {
-	$exercise = new Exercises($id);
-	if ($exercise->getStatus() === Status::Building && $exercise->getFieldsCount() > 0) {
-		$exercise->setExerciseAs(Status::Answering);
+	if (!isset($_GET['exercise']['status'])) {
+		badRequest();
+		return;
 	}
-	header('Location: /exercises');
-}
-function setExerciseAsClosed(int $id)
-{
-	$exercise = new Exercises($id);
-	if ($exercise->getStatus() === Status::Answering) {
-		$exercise->setExerciseAs(Status::Closed);
+
+	$exercise = null;
+	try {
+		$exercise = new Exercises($id);
+	} catch (Exception) {
+		lost();
+		return;
 	}
+
+	if ($exercise->getFieldsCount() < 1) {
+		badRequest();
+		return;
+	}
+
+	switch ($_GET['exercise']['status']) {
+		case 'answering' && $exercise->getStatus() == Status::Building:
+			$exercise->setExerciseAs(Status::Answering);
+			break;
+		case 'closed' && $exercise->getStatus() == Status::Answering:
+			$exercise->setExerciseAs(Status::Closed);
+			break;
+		default:
+			badRequest();
+			return;
+	}
+
 	header('Location: /exercises');
 }