feat: Add field validation to prevent empty exercises from being set …

…as answers
CPNV-ES · Oct 9, 2024 · bcb52cd · bcb52cd
1 parent 26856ef
commit bcb52cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/controllers/exercise_controller.php b/src/controllers/exercise_controller.php
@@ -16,7 +16,7 @@ function createExercise()
 function setExerciseAsAnswering(int $id)
 {
 	$exercise = new Exercises($id);
-	if ($exercise->getStatus() === Status::Building) {
+	if ($exercise->getStatus() === Status::Building && $exercise->getFieldsCount() > 0) {
 		$exercise->setExerciseAs(Status::Answering);
 	}
 	header('Location: /exercises');

diff --git a/src/views/manage_an_exercise.php b/src/views/manage_an_exercise.php
@@ -28,8 +28,10 @@
           <tr>
             <td><?= $exercise->getTitle() ?></td>
             <td>
-              <a title="Be ready for answers" rel="nofollow" data-method="put"
-                href="/exercises/<?= $exercise->getId() ?>?exercise%5Bstatus%5D=answering"><i class="fa fa-comment"></i></a>
+              <?php if ($exercise->getFieldsCount() > 0) {?>
+                <a title="Be ready for answers" rel="nofollow" data-method="put"
+                  href="/exercises/<?= $exercise->getId() ?>?exercise%5Bstatus%5D=answering"><i class="fa fa-comment"></i></a>
+              <?php }?>
               <a title="Manage fields" href="/exercises/<?= $exercise->getId() ?>/fields"><i class="fa fa-edit"></i></a>
               <a data-confirm="Are you sure?" title="Destroy" rel="nofollow" data-method="delete"
                 href="/exercises/<?= $exercise->getId() ?>"><i class="fa fa-trash"></i></a>