Add some changes #42
Open
Add some changes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajout du zoom sur la voiture courante avec les touches F2 et F3. Ajout du changement de voiture aléatoire avec la touche F1.
Création de l'objet savePrefab pour l'enregistrement fonctionnelle mais recréation de celui-ci depuis le fichier save.json impossible.
greut
reviewed
Sep 18, 2018
| @@ -51,7 +51,7 @@ public void EditionRoute(Orientation orientation) | |||
| default: | |||
| break; | |||
| } | |||
| Route.DictionaireObstacles = dico; | |||
| Route.DictionnaireObstacles = dico; | |||
greut
reviewed
Sep 18, 2018
| case Orientation.OUEST: | ||
| return Orientation.EST; | ||
| } | ||
| return Orientation.NORD; |
There was a problem hiding this comment.
si Orientation.SUD est (aussi) le default, vous gagnerez en clareté.
greut
reviewed
Sep 18, 2018
| :base(rectangle, v, vMax) | ||
| { | ||
|
|
||
| } |
There was a problem hiding this comment.
est-ce vraiment requis de redéfinir chaque constructeur?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout du zoom/dézoom sur la voiture.
Ajout centrage caméra sur la voiture.
Ajout changement de voiture aléatoire et centrage sur la nouvelle.
Ajout sauvegarde mais pas restauration.
PS: Pour la sauvegarde j'ai utilisé newtonjson avec une class savePrefab qui stock toutes les informations.
Le seul problème c'est lorsque je dois recréer l'objet savePrefab depuis le fichier json, pour directement passer les informations au panel, j'ai une erreur de constructeur voiture.