Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default behavior was to silently log errors. #5

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

MohitYadav-codes
Copy link
Collaborator

Now it will throw , unless passsed a cli flag to not throw errors

throw_errors is more pythonic in code
Copy link
Collaborator

@vrraikar vrraikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MohitYadav-codes MohitYadav-codes merged commit 1c44e46 into main Jun 17, 2024
2 checks passed
@MohitYadav-codes MohitYadav-codes deleted the throw_errors branch June 17, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants