Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync scheduler overhaul #15

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

carykees98
Copy link
Collaborator

No description provided.

@lavajuno
Copy link
Collaborator

Good stuff, looking forward to getting this up and running.

@Warvan1
Copy link
Member

Warvan1 commented Nov 21, 2024

Its hard to tell what parts of this is actually changing functionality because 99% of the diff is just changing the code formatting. (the new formatting is also harder to read than the old formatting)

@lavajuno
Copy link
Collaborator

I think a lot of this is refactoring to make it easier to add/change functionality later. We still need to do some work on manual sync before it's up and running, we're also experiencing a lot of #13 in production.

@Warvan1
Copy link
Member

Warvan1 commented Nov 21, 2024

why did you change all the function definitions to the following format?

auto Schedule::getInstance() -> Schedule*
{
//code
}

this is WAY harder to read especially for newer students. Also I like to avoid auto (except for some cases like range for loops).

Also I am resisting the urge to nitpick all of the other weird formatting but I couldn't ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants