Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All tasks completed. #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

PaRaDoX50
Copy link

No description provided.

@mohit-mangal
Copy link
Collaborator

@PaRaDoX50

  • After deleting mail for description page, some pop up should be there to notify the user that mail is deleted
  • There should be a sender email by default, no headers were there for cc and bcc.
  • when search result is empty, the image is not shown as it ought to according to your code, check that part.
  • Notify users for their actions like mail sent, deleted.

@mohit-mangal
Copy link
Collaborator

Remarks -
Your have used very good features in code. Excellent Work!!! 😄

@mohit-mangal mohit-mangal self-requested a review June 7, 2020 16:28
@nishantkr18
Copy link
Member

Thanks for participating! I've made changes to github workflows now, so go ahead and merge master into your branch if you want to have your test fixed. You should add all your work inside a directory named gmailapp, otherwise the tests will fail. Github actions will build your apk directly from your source files, and upload it as artifacts. You can visit your test after it passes, to downoad your built apk. For any queries, drop a message on the telegram group or pm.

And lastly, we have been working on the institute app for some time, and uses flutter. Here's the link. Currently, the work is on hold, but we shall continue after examinations. If you are interested to work, feel free to build the apk locally, add an issue if you find a bug, fix existing issues or add documentation. For backend, we use https://workshops-app-backend.herokuapp.com/ from here.

Keep contributing and stay safe.

@PaRaDoX50
Copy link
Author

Remarks -
Your have used very good features in code. Excellent Work!!!

Thank You!

@PaRaDoX50

  • After deleting mail for description page, some pop up should be there to notify the user that mail is deleted
  • There should be a sender email by default, no headers were there for cc and bcc.
  • when search result is empty, the image is not shown as it ought to according to your code, check that part.
  • Notify users for their actions like mail sent, deleted.

Thanks for the review and suggestions!

@PaRaDoX50
Copy link
Author

@PaRaDoX50

  • After deleting mail for description page, some pop up should be there to notify the user that mail is deleted
  • There should be a sender email by default, no headers were there for cc and bcc.
  • when search result is empty, the image is not shown as it ought to according to your code, check that part.
  • Notify users for their actions like mail sent, deleted.

Bhaiya, the "no result" image file is correctly showing up on my device.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants