Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All tasks Done #10

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

All tasks Done #10

wants to merge 6 commits into from

Conversation

dasari810
Copy link

Completed all the tasks

@nishantkr18
Copy link
Member

Thanks for participating! I've made changes to github workflows now, so go ahead and merge master into your branch if you want to have your test fixed. You should add all your work inside a directory named gmailapp, otherwise the tests will fail. Github actions will build your apk directly from your source files, and upload it as artifacts. You can visit your test after it passes, to downoad your built apk. For any queries, drop a message on the telegram group or pm.

And lastly, we have been working on the institute app for some time, and uses flutter. Here's the link. Currently, the work is on hold, but we shall continue after examinations. If you are interested to work, feel free to build the apk locally, add an issue if you find a bug, fix existing issues or add documentation. For backend, we use https://workshops-app-backend.herokuapp.com/ from here.

Keep contributing and stay safe.

@nishantkr18
Copy link
Member

Hey @MadhavaDasari , nice work. A few issues:

  1. The images and GIFs u've used are disproportionate. There are a lot of flutter widgets to help you with that.
  2. I am not able to compose a mail properly. You can make several improvements on it if you want. Check the gmail app for references.
    Thanks 👍

@dasari810
Copy link
Author

@nishantkr18 thank for the review ... Can i please know what is the exact issue that you are facing while composing the mail so that i can improve it

@nishantkr18
Copy link
Member

@nishantkr18 thank for the review ... Can i please know what is the exact issue that you are facing while composing the mail so that i can improve it

After pressing the compose button, nothing happens, the loading gif appears and then it returns to the home screen with no change. If it fails, a proper message should be displayed otherwise how will people know what the error is? They will assume that the app is faulty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants