This repository has been archived by the owner on Sep 7, 2019. It is now read-only.
Soap Header Response Workflow #1659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmith2
requested review from
TabassumJafri,
mhpnguyen,
ptambellini01,
trantang and
plobre
plobre
reviewed
May 21, 2018
| @@ -85,7 +88,7 @@ public void testrespondingGatewayCrossGatewayQueryforNullEndPoint() throws Excep | |||
| NhinTargetSystemType target = null; | |||
| final DocQueryAuditLogger auditLogger = getAuditLogger(true); | |||
| AssertionType assertion = new AssertionType(); | |||
|
|
|||
| StandardOutboundDocQuery entitydocqueryimpl = new StandardOutboundDocQuery(strategy, service, policyChecker) { | |||
There was a problem hiding this comment.
Instead of creating a new class definition and copy/pasting the same code 5 times in this file, perhaps a helper method to give you this object could be used? Smaller file size, less number of lines, and easier to maintain in the future.
There was a problem hiding this comment.
Agree. Ignore the unit tests for now. Review is to determine if method of passing headers is effective and if the team has any better ways of doing it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to send SOAP header values from responding adapter to NwHIN response and also pull SOAP headers from NwHIN response and pass to requesting adapter.
This PR is for team review and only covers Document Query. After review, other needed services (PD/DR) will be updated and a regression test will also be added.