Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply minor cosmetic changes #70

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

vaitkus
Copy link
Collaborator

@vaitkus vaitkus commented Feb 7, 2024

This PR deals mostly with cosmetic changes.

The dotless data names were changed to the main dotted data names (e.g. _cell_wave_vector_seq_id to _cell_wave_vector.seq_id) in the human-readable text and examples since these are the preferred names.

Note, that this PR also inadvertently corrects some of the category examples since not all dotless names used in the examples are defined in the dictionaries (e.g. _atom_site_moment_Fourier.atom_site_label is defined while the _atom_site_moment_Fourier_atom_site_label alias is not).

@vaitkus vaitkus marked this pull request as ready for review February 7, 2024 13:29
@vaitkus vaitkus merged commit 11bdf26 into COMCIFS:main Feb 8, 2024
2 checks passed
@vaitkus vaitkus deleted the apply-minor-cosmetic-changes branch February 8, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant