Post community review #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type and _diffrn.precession_angle to _diffrn.precession_semi_angle (and corresponding *_su term).
…d recommendations.md updated accordingly.
mostlt relating to changes from _refine_diff.density_* to *.potential_*
vaitkus
reviewed
Dec 18, 2024
Description of _diffrn_scan_frame.scale_factor_su fixed. Co-authored-by: Antanas Vaitkus <[email protected]>
docs/recommendations.md updated with many helpful editorial improvements suggested by Antanas Vaitkus.
vaitkus
reviewed
Dec 31, 2024
Co-authored-by: Antanas Vaitkus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron diffraction CIF dictionary revised extensively following community discussions. Ancillary documentation updated accordingly. New proto-dictionary draft_new_items.dic also created as scratchpad for possible extensions to the imgCIF dictionary.
Note validation of cif_ed.dic will fail on _units.code values reciprocal_angstroms_per_pixel and electrons_per_angstrom. These will be submitted as a PR to templ_enum.cif pending acceptance of this new dictionary.