Fix duplicate enumeration values of _atom_local_axes.ax* data items
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_atom_local_axes.ax1and_atom_local_axes.ax2data items define several enumeration values which only differ in the letter case ('x' and 'X', '+y' and '+Y', etc.). The currently assigned 'Code' content type is case-insensitive, thus such values are considered identical. Changing the content type to 'Word' resolves this issue.Alternatively, the uppercase or lowercase enumeration values could be removed without changing the content type, but, IMHO, having them all listed is a bit clearer.
All of these enumeration values were ported from the DDL1 version of the CIF_RHO dictionary [1].
[1] https://www.iucr.org/__data/iucr/cif/dictionaries/cif_rho.dic