Adds support for hosting sites other than GitHub. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
changed the title
|
🚀 [bumpr] Bumped! New version:v1.1.4 Changes:v1.1.3...v1.1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
Right now CMaize will crash if
URLon a dependency is to any site other than GitHub (this isbecause the internals actually manipulate the URL and are thus tied to GitHub's interface). This PR creates a new class which works with arbitrary URLs; however, the resulting class is less feature-rich (no private repos for example). Ultimately the internal logic dispatches to the old GitHub class if the url is for GitHub and the new class otherwise.
TODOs
Tests.
Edit: Apparently you can't use FetchContent in scripting mode, which makes it hard to test fetching from somewhere other than GitHub (which also isn't tested). Instead I've verified that these changes work in TensorWrapper (where I needed Eigen, which is hosted on GitLab)