Adds find_optional_dependency #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachcran
requested changes
Dec 22, 2023
cmake/cmaize/user_api/dependencies/impl_/check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
cmake/cmaize/user_api/dependencies/impl_/check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
cmake/cmaize/user_api/dependencies/impl_/check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
cmake/cmaize/user_api/dependencies/impl_/check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
cmake/cmaize/user_api/dependencies/impl_/check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
tests/cmaize/user_api/dependencies/impl_/test_check_optional_flag.cmake
Outdated
Show resolved
Hide resolved
tests/cmaize/user_api/dependencies/test_find_optional_dependency.cmake
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachery Crandall <[email protected]>
|
🚀 [bumpr] Bumped! New version:v1.0.0 Changes:v0.3.2...v1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
This is a partial response to #120, but not a solution.
Description
This PR provides the
find_optional_dependencyfunction which in turn allows me to simplify how PluginPlay's CMakeLists.txt handles RocksDB. I also am going to call this the cutoff feature for the JCP paper, hence merging this PR will officially bump CMaize to 1.0.0.TODOs
None. R2g.