Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

113 #138

Merged
merged 20 commits into from
Dec 11, 2023
Merged

113 #138

merged 20 commits into from
Dec 11, 2023

Conversation

ryanmrichard
Copy link
Collaborator

@ryanmrichard ryanmrichard commented Nov 30, 2023

Is this pull request associated with an issue(s)?
Fixes #113

Description
Describe what this pull request will accomplish.

TODOs

  • Test ProjectSpecification.get_config_option() throws.
  • Test CMaizeProject.set_config_option() (and the getter)
  • Finish documenting above
  • Implement cmaize_option

@ryanmrichard ryanmrichard self-assigned this Nov 30, 2023
@ryanmrichard
Copy link
Collaborator Author

@zachcran any idea what's still wrong with the integration tests?

@zachcran
Copy link
Contributor

zachcran commented Dec 4, 2023

@ryanmrichard It looks like we are losing the lib directory somewhere. The install path for the library is /path/to/install/CMaizePrivateDepend/external/../../../CMaizePrivateDepend/libCMaizePrivateDepend.so.1.0.0 instead of /path/to/install/lib/CMaizePrivateDepend/external/../../../CMaizePrivateDepend/libCMaizePrivateDepend.so.1.0.0. I think this happened when you merged master with that last commit.

@ryanmrichard ryanmrichard mentioned this pull request Dec 11, 2023
Comment on lines +111 to +112

# Import target \"${__gtc_namespace}${__gtc_target_name}\" for configuration \"???\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Import target \"${__gtc_namespace}${__gtc_target_name}\" for configuration \"???\"
# TODO: Handle different configurations (Release, Debug, etc.)
# Import target \"${__gtc_namespace}${__gtc_target_name}\" for configuration \"???\"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this, but I'll put it into my next PR.

cmake/cmaize/user_api/cmaize_option.cmake Outdated Show resolved Hide resolved
cmake/cmaize/user_api/cmaize_option.cmake Outdated Show resolved Hide resolved
cmake/cmaize/user_api/cmaize_option.cmake Outdated Show resolved Hide resolved
tests/cmaize/user_api/test_cmaize_option.cmake Outdated Show resolved Hide resolved
tests/cmaize/user_api/test_cmaize_option.cmake Outdated Show resolved Hide resolved
@ryanmrichard ryanmrichard merged commit a2fbcd2 into master Dec 11, 2023
6 checks passed
@ryanmrichard ryanmrichard deleted the 113 branch December 11, 2023 21:15
Copy link

🚀 [bumpr] Bumped! New version:v0.2.2 Changes:v0.2.1...v0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cmaize_option
2 participants