Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable integration tests on Mac systems #136

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

zachcran
Copy link
Contributor

@zachcran zachcran commented Nov 6, 2023

Is this pull request associated with an issue(s)?
No.

Description
Currently, shared library file extensions are hard-coded in the integration tests for Linux systems. Mac systems generate different shared library file extensions, so the integration tests fail on Mac. This PR updates the integration test scripts to detect if they are running on a Mac and use the appropriate file extensions.

TODOs

  • Ensure that integration tests work on Mac.
  • Ensure that integration tests still work on Linux.

@zachcran zachcran added the bump:patch Increments the patch version. label Nov 6, 2023
@zachcran zachcran self-assigned this Nov 6, 2023
@zachcran zachcran marked this pull request as draft November 6, 2023 19:24
@zachcran zachcran marked this pull request as ready for review November 6, 2023 19:32
@zachcran zachcran requested a review from ryanmrichard November 6, 2023 19:32
@zachcran zachcran enabled auto-merge November 6, 2023 19:32
@zachcran zachcran merged commit 0873fe8 into master Nov 6, 2023
8 checks passed
@zachcran zachcran deleted the integration_tests_mac branch November 6, 2023 19:55
Copy link

github-actions bot commented Nov 6, 2023

🚀 [bumpr] Bumped! New version:v0.1.9 Changes:v0.1.8...v0.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Increments the patch version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants