-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background #132
Background #132
Conversation
@AutonomicPerfectionist I have a weird bug. If you pull this branch and try to configure it ( The actual message call seems fine to me (right now it's literally a string because I took the |
FWIW, I realize this bug is better reported in the CMakeTest repo, but I'm not sure what combination of interactions is causing the bug in order to piece together a MWE. |
Infinite recursion in that override is a recurring (heh) problem, it usually happens because a fatal error is thrown somewhere along the exception handling route, which then starts the recursion over again. I'll take a look in a bit |
Well this is a new one, somehow the overrides are being included more than once even though there's an include_guard, so the underscore function is overridden as well. Commenting out the |
@ryanmrichard a small fix in CMakeTest appears to solve it at first glance, probably should do some more tests before merging it though |
@AutonomicPerfectionist Thanks for fixing that so fast! As for more testing, it looks like it fixes this problem; so I'm fine merging it and revisiting the issue if something else comes up. |
@zachcran I'm going to freeze this PR here. It quickly got away from me. As I think you'll see this PR really will be the bulk of the paper's background. In preparing that, I really wanted to showcase the simplicity of CMaize vs. CMake. For this reason I wanted code snippets. This led me to needing to unit test the documentation examples to ensure I wasn't missing something (they really did work as advertised). This then led to me basically re-inventing some of what I think underlies your integration tests, though they're run out of this repo in a hopefully platform agnostic way. Basically:
|
It looks like me defaulting the C++ version to 98 (when nothing is selected broke things. I'm going to try going back to the old behavior (no value) and skipping the relevant line in |
@ryanmrichard Sorry for the delay. I'll take a look at this over the weekend! |
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
Co-authored-by: Zachery Crandall <[email protected]>
🚀 [bumpr] Bumped! New version:v0.1.11 Changes:v0.1.10...v0.1.11 |
Is this pull request associated with an issue(s)?
No
Description
This PR adds some background to the CMaize documentation.
TODOs