Fix CMake issues for using Ramulator as a dependency in other projects #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Properly propagate include directories in CMake. - Add a install target in CMake. - Call Logging::_create_base_logger in logging.cpp instead of logging.h Important: The executable will no longer be copied to the project root. Instead, it will reside in the CMake build folder. Use make install to move it to a designated permanent location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily involves modifications to the project's CMakeLists.txt files. The goal was to enable the use of Ramulator2 as a CMake dependency for other projects. For more details, please refer to the commit messages.