Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buggy state added #102

Merged
merged 3 commits into from
Jun 30, 2024
Merged

buggy state added #102

merged 3 commits into from
Jun 30, 2024

Conversation

TiaSinghania
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

just added a buggystate file, currently should be able to replace world and telematics entirely (eventually should replace pose)

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

Copy link
Collaborator

@mehulgoel873 mehulgoel873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code within this file makes sense, I just had a question on how to use this file.

Is the idea that each ros node that needs the buggy's state, to init one of these objects, which will continuously update the position and yaw? If so, are we sure that those topics are correct for NAND because we don't get a quaternion for nand's position right?

I think the overall file makes sense, although I'm a little confused on how to use this file. Is the idea that we create objects each time we need to represent a buggy state, and continuously update it with the information we get from the different odom messages? So each ros node that needed a buggy state would individually initiliaze an object of the buggy state class?

rb_ws/src/buggy/scripts/auton/buggystate.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/auton/buggystate.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/scripts/auton/buggystate.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mehulgoel873 mehulgoel873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

rb_ws/src/buggy/scripts/auton/buggystate.py Show resolved Hide resolved
rb_ws/src/buggy/scripts/auton/buggystate.py Outdated Show resolved Hide resolved
@mehulgoel873 mehulgoel873 merged commit d5ba5c5 into main Jun 30, 2024
3 checks passed
@mehulgoel873 mehulgoel873 deleted the samanvis_buggy_state_2 branch June 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants