Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

fix(views/SignIn): add missing autocomplete username #119

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sbolel
Copy link
Contributor

@sbolel sbolel commented Aug 8, 2023

Summary

This PR adds autocomplete="username" attribute to the email field in the signin form, which was missed in #114

Added

Changed

  • Adds an autocomplete attribute to the email field in views/SignIn
  • Removes the autoComplete="off" prop from the form element

Deprecated

Removed

Fixed

  • Fixes the console warning:
    [DOM] Input elements should have autocomplete attributes (suggested: "username"): (More info: https://goo.gl/9p2vKq) <input aria-invalid=​"false" id=​"email-input" placeholder=​"[email protected]" type=​"text" aria-labelledby=​"email-label" class=​"MuiInputBase-input MuiOutlinedInput-input css-lcbzx0-MuiInputBase-input-MuiOutlinedInput-input" value>​…​</input>​
    

How to test

  • yarn start
  • go to the login screen
  • confirm that you can autofill the fields
  • confirm there is no warning in the console

@sbolel sbolel added the bug This issue or PR is for something not working label Aug 8, 2023
@sbolel sbolel self-assigned this Aug 8, 2023
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbolel sbolel merged commit 627025c into main Aug 11, 2023
1 check passed
@sbolel sbolel deleted the fix/signin-autocomplete-username branch August 11, 2023 20:40
@github-actions
Copy link

🎉 This PR is included in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released This has been released label Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue or PR is for something not working released This has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants