Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-3131] [EASI-3129] Threaded Discussions #703

Merged
merged 12 commits into from
Sep 29, 2023
Merged

[EASI-3131] [EASI-3129] Threaded Discussions #703

merged 12 commits into from
Sep 29, 2023

Conversation

OddTomBrooks
Copy link
Contributor

@OddTomBrooks OddTomBrooks commented Sep 19, 2023 •
edited by ClayBenson94
Loading

EASI-3131, EASI-3129

Changes and Description

  • Removed DiscussionStatus enum from schema
  • Removed Resolution from DiscussionReply
  • Updated most front-end references

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

StevenWadeOddball
StevenWadeOddball reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom, I know it's still in draft, but I figured I'd take a look since the timing worked out well for me. The backend looks pretty good! The only thing I noticed is that Discussion status is only removed from GQL, and still exists in GO and the DB.

pkg/graph/schema.graphql Show resolved Hide resolved
ClayBenson94 and others added 6 commits September 20, 2023 12:30
@ClayBenson94
Merge branch 'main' into feature/EASI-3131_threaded_replies
5769868
@OddTomBrooks
feat: removed discussion status from go and sql
9dbe681
@OddTomBrooks
Merge branch 'feature/EASI-3131_threaded_replies' of github.com:CMSgo…
fd4db24 
…v/mint-app into feature/EASI-3131_threaded_replies
@OddTomBrooks
chore: removed references to discussion status from plan discussion sql
58f40be
@garyjzhao @dependabot
@Jdwoodson @StevenWadeOddball @ClayBenson94 @patrickseguraoddball @OddTomBrooks
[EASI-3129] FE -- threaded replies (#719)
15bec22 
* Change from Question verbiage to Discussion verbiage per Figma

* deleted format activity

* update recent activity in home page table

* only show the discussions if there is more than 0

* various empty states

* add a period after the link

* working through the styles

* Starting a discussion label updates

* adding various text updates

* add more copy eidts

* answer -> reply

* good work so far

* add a replies compnent

* resplies

* show/hide replies

* wip on replies

* specificity over BANGimportant

* DRYing code by having DiscussionUserInfo

* pass down index

* cleaning up padding/margins

* wip

* pass down replies object as prop

* add getDaysElapsed function

* implement the date adn time to show on replies

* fix typeerror and more conditional rendering

* remove comment

* remove hasEditAccess

* drying up some code

* adding the connected styles

* Add the conected border styles

* Build(deps): bump github.com/contribsys/faktory from 1.7.0 to 1.8.0 (#711)

Bumps [github.com/contribsys/faktory](https://github.com/contribsys/faktory) from 1.7.0 to 1.8.0.
- [Release notes](https://github.com/contribsys/faktory/releases)
- [Changelog](https://github.com/contribsys/faktory/blob/main/Changes.md)
- [Commits](contribsys/faktory@v1.7.0...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/contribsys/faktory
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* desctructure the prop to only use replies

* Read more toggle when there are more than four replies

* change div to span so no div within p descendant error

* major progress

* increase the character limit

* EASI-3236: skip_tests feature for manual deployment (#709)

EASI-3236: init skip_tests feature for manual deployment

* [EASi 3154] links as documents be (#710)

* feat: add the ability to add a document which a link to an outside document

* feat: add unit test for a linked document

* feat: add note about the fact that we dont virus scan a linked document. Add URL format validation and unit test

* feat: add postman query for upoloading a linked document

* feat: constraint to not allow url to be null if is_link, and require null if !is_link. More explicit url validation

* Added tests for other types of URLs

---------

Co-authored-by: ClayBenson94 <[email protected]>

* adjust the spacing between the replies

* made some more chagnes

* [EASI-2842] - Model home table updates (#705)

* Modified columns on home tables and updated MAC heading text

* Update snap

* Merged all model plan tables

* Fixed model link and adjusted header table styling

* Fix mispelled basics and change parent category map key

---------

Co-authored-by: Clay Benson <[email protected]>

* [NOREF] Split docker compose files (#707)

* Split docker compose files by frontend + backend, rather than by regular/override. Remove most duplicative env vars

* Fix typo in docker compose file

* Use PGPASSWORD instead of PGPASS

* Use PGPASS and PGPASSWORD

* Remove unused Dockerfiles (client CI and cypress). Rename Dockerfile.client to Dockerfile.frontend, refactor to no longer copy source and use alpine base image

* Remove templates for emails (they are embedded in the binary). Refactor dockerfile for backend.

* [NOREF] Fix dockerfile copy command copying to wrong directory (#714)

Fix dockerfile copy command copying to wrong directory

* Build(deps): bump docker/setup-buildx-action from 2 to 3 (#715)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [NOREF] Delete RDS manual snapshots  (#718)

Delete RDS manual snapshots until there are 10 remaining to ensure we do not hit the limit of 100 manual snapshots

* [Easi 3130]/discussion tagging adr (#706)

* feat: discussion tagging ADR

Co-authored-by: Patrick Segura <[email protected]>

* NOREF Remove unused deprecated search queries (#712)

* chore: remove unused deprecated search queries. Base resolver code retained

* feat: remove unused queries from postman collection

* redo how the accordion works

* move accordion to its own component

* add stautus pback

* Remove commented code

* remove more commented code

* update snaps for ton of things

* update tests

* fixing duplicated name migrations

* Build(deps): bump the other group with 2 updates (#716)

Bumps the other group with 2 updates: [github.com/99designs/gqlgen](https://github.com/99designs/gqlgen) and [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go).


Updates `github.com/99designs/gqlgen` from 0.17.37 to 0.17.38
- [Release notes](https://github.com/99designs/gqlgen/releases)
- [Changelog](https://github.com/99designs/gqlgen/blob/master/CHANGELOG.md)
- [Commits](99designs/gqlgen@v0.17.37...v0.17.38)

Updates `github.com/aws/aws-sdk-go` from 1.45.12 to 1.45.15
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.45.12...v1.45.15)

---
updated-dependencies:
- dependency-name: github.com/99designs/gqlgen
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: other
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Clay Benson <[email protected]>

* linting

* Update discussion e2e test

* fix: updated plan discussion unit tests to drop status

* using regex to find the correct button

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Woodson <[email protected]>
Co-authored-by: Steven Wade <[email protected]>
Co-authored-by: ClayBenson94 <[email protected]>
Co-authored-by: Patrick Segura <[email protected]>
Co-authored-by: Patrick Segura <[email protected]>
Co-authored-by: Tom Brooks <[email protected]>
@ClayBenson94
Merge main
27d5e26
@OddTomBrooks OddTomBrooks marked this pull request as ready for review September 28, 2023 17:26
@OddTomBrooks OddTomBrooks requested review from a team as code owners September 28, 2023 17:26
@OddTomBrooks OddTomBrooks requested review from StevenWadeOddball and garyjzhao and removed request for a team September 28, 2023 17:26
@ClayBenson94 ClayBenson94 changed the title [EASI-3131] Threaded Discussions [EASI-3131] [EASI-3129] Threaded Discussions Sep 28, 2023
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for garyjzhao September 28, 2023 17:30
@garyjzhao
Copy link
Contributor

@patrickseguraoddball we merged in the FE work into this branch. if it helps, this is the OG PR

StevenWadeOddball
StevenWadeOddball requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OddTomBrooks , this looks looks good overall. Could you please update the postman collection? I also did a quick functional test on the front end and it worked as expected.

MINT.postman_collection.json Outdated Show resolved Hide resolved
ClayBenson94
ClayBenson94 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes work locally, looks great! Thanks @OddTomBrooks and @garyjzhao !

@OddTomBrooks OddTomBrooks merged commit 561c9f9 into main Sep 29, 2023
10 checks passed
@OddTomBrooks OddTomBrooks deleted the feature/EASI-3131_threaded_replies branch September 29, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenWadeOddball StevenWadeOddball StevenWadeOddball approved these changes

@ClayBenson94 ClayBenson94 ClayBenson94 approved these changes

@patrickseguraoddball patrickseguraoddball Awaiting requested review from patrickseguraoddball

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OddTomBrooks @garyjzhao @ClayBenson94 @StevenWadeOddball