Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] - Fixed task list last updated #657

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

patrickseguraoddball
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball commented Aug 1, 2023

NOREF

Changes and Description

The last updated time on IT Solutions in the task list was incorrect. There was an incorrect non-null assertion, where null values were actually being passed. This causes an incorrect datestring comparison.

Slack thread

  • Filtered for null values before comparing
  • Added unit test

How to test this change

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@patrickseguraoddball patrickseguraoddball requested a review from a team as a code owner August 1, 2023 18:14
@patrickseguraoddball patrickseguraoddball requested review from garyjzhao and removed request for a team August 1, 2023 18:14
@patrickseguraoddball patrickseguraoddball changed the title [NROEF] - Fixed task list last updated [NOREF] - Fixed task list last updated Aug 1, 2023
@patrickseguraoddball patrickseguraoddball marked this pull request as draft August 1, 2023 18:53
@patrickseguraoddball patrickseguraoddball marked this pull request as ready for review August 1, 2023 19:08
@patrickseguraoddball patrickseguraoddball merged commit 42b080d into main Aug 2, 2023
9 checks passed
@patrickseguraoddball patrickseguraoddball deleted the NOREF/updated-task-time-fix branch August 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants