Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EASI-2713] Email Notification on Model Plan Dates Changed - Updates to Include All Fields #651

Merged
merged 71 commits into from
Aug 1, 2023
Merged

[EASI-2713] Email Notification on Model Plan Dates Changed - Updates to Include All Fields #651

merged 71 commits into from
Aug 1, 2023

Conversation

OddTomBrooks
Copy link
Contributor

EASI-2713

Changes and Description

  • Improvements to include all plan basics fields in model plan dates changed

How to test this change

  • Follow same steps as previous EASI-2713 Plan Basics changes testing
    • Modify dates in plan basics
    • Review resulting email in mailcatcher

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

OddTomBrooks and others added 30 commits June 6, 2023 11:27
@OddTomBrooks
feat: add ams model id and other fields to general characteristics
01e35fa
@OddTomBrooks
Merge branch 'main' into EASI-2899/backend_add_demo_code_other_fields
89fb650
@OddTomBrooks
chore: migrated model abbreviation to model plan
57845e4
@OddTomBrooks
Merge branch 'EASI-2899/backend_add_demo_code_other_fields' of github…
a8c14f8 
….com:CMSgov/mint-app into EASI-2899/backend_add_demo_code_other_fields
@OddTomBrooks
chore: add role to plan discussion, begin updating store queries
4906c1d
@OddTomBrooks
feat: updated sql to include role
e5e51bd
@OddTomBrooks
chore: updated user_role naming to be consistent, fix: most recent di…
4a5fb01 
…scussion role endpoint
@OddTomBrooks
chore: updated postman collection
153a976
@OddTomBrooks
Merge branch 'main' into EASI-3000/read_view_users_contribute_discuss…
c503598 
…ions

# Conflicts:
#	MINT.postman_collection.json
#	migrations/V95__Update_Model_Plan_Abbreviation.sql
#	pkg/models/model_plan.go
#	pkg/storage/SQL/model_plan/collection_by_collaborator.sql
#	pkg/storage/SQL/model_plan/collection_where_archived.sql
#	pkg/storage/SQL/model_plan/collection_where_favorited.sql
#	pkg/storage/SQL/model_plan/collection_with_crtdl.sql
#	pkg/storage/SQL/model_plan/create.sql
#	pkg/storage/SQL/model_plan/get_by_id.sql
#	pkg/storage/SQL/model_plan/get_by_id_LOADER.sql
#	pkg/storage/SQL/model_plan/get_by_name.sql
#	pkg/storage/SQL/model_plan/update.sql
@OddTomBrooks
Merge branch 'main' into EASI-3000/read_view_users_contribute_discuss…
da4c803 
…ions
@OddTomBrooks
chore: cleaned up old migration
1292e35
@OddTomBrooks
Merge branch 'EASI-3000/read_view_users_contribute_discussions' of gi…
79db26c 
…thub.com:CMSgov/mint-app into EASI-3000/read_view_users_contribute_discussions
@OddTomBrooks
chore: removed testing code
66166ac
@OddTomBrooks
chore: removed old ghost code from branch-off
12e80e7
@OddTomBrooks
chore: go mod tidy
acee4e3
@OddTomBrooks
fix: updated inputs to fix broken tests
94a1407
@OddTomBrooks
fix: added user role to plan discussion test inputs
006d23f
@OddTomBrooks
chore: updated postman collection
d875313
@OddTomBrooks
Merge branch 'main' into EASI-3000/read_view_users_contribute_discuss…
15bfc75 
…ions
@OddTomBrooks
feat: added user role description to plan discussion with constraints…
9da9c95 
… and unit tests
@OddTomBrooks
Merge branch 'EASI-3000/read_view_users_contribute_discussions' of gi…
ce34d86 
…thub.com:CMSgov/mint-app into EASI-3000/read_view_users_contribute_discussions
@OddTomBrooks
wip: email notifications when model plan dates change
2abfd1f
@OddTomBrooks
fix: reverted file to main version
a08fcd6
@OddTomBrooks
chore: removed debug print code
2dda5fc
@OddTomBrooks
chore: fix sql constraints, remove trigger
7525899
@OddTomBrooks
wip: bug fixes and refactoring
dc6c7f8
@OddTomBrooks
fix: added userRole and userRoleDiscussion to discussion replies, imp…
4d278f0 
…roved constraints
@OddTomBrooks
fix: server tests relating to discussion reply create input
f62fa35
@OddTomBrooks
chore: simplified email recipients table, added email recipient seeding
ede9da7
@OddTomBrooks
Merge branch 'EASI-3000/read_view_users_contribute_discussions' into E…
01b9f47 
…ASI-2713/email_notif_on_model_plan_dates_changed
OddTomBrooks and others added 20 commits July 18, 2023 13:25
@OddTomBrooks
chore: updated unit tests
986805b
@OddTomBrooks
Merge branch 'main' into EASI-2713/email_notif_on_model_plan_dates_ch…
63a3368 
…anged
@OddTomBrooks
chore: removed debug print and updated gomod
47aa771
@OddTomBrooks
Merge branch 'EASI-2713/email_notif_on_model_plan_dates_changed' of g…
62ea129 
…ithub.com:CMSgov/mint-app into EASI-2713/email_notif_on_model_plan_dates_changed
@OddTomBrooks
chore: removed gomod change
95e446a
@OddTomBrooks
chore: simplified template and removed unnecessary data structure sim…
8582665 
…plifying conversion code
@OddTomBrooks
Merge branch 'main' into EASI-2713/email_notif_on_model_plan_dates_ch…
f530c75 
…anged
@OddTomBrooks
chore: restructured code and removed debug print statements
81601cc
@OddTomBrooks
Merge branch 'EASI-2713/email_notif_on_model_plan_dates_changed' of g…
c80e5d9 
…ithub.com:CMSgov/mint-app into EASI-2713/email_notif_on_model_plan_dates_changed
@OddTomBrooks
fix: date change evaluation bugs
d408bd4
@ClayBenson94
Merge branch 'main' into EASI-2713/email_notif_on_model_plan_dates_ch…
dc19e69 
…anged
@OddTomBrooks
chore: removed print statements, added test coverage TODOs
310882d
@OddTomBrooks
Merge branch 'EASI-2713/email_notif_on_model_plan_dates_changed' of g…
2f0a89d 
…ithub.com:CMSgov/mint-app into EASI-2713/email_notif_on_model_plan_dates_changed
@OddTomBrooks
chore: added test coverage to plan_basics_helper
7c958bc
@OddTomBrooks
Merge branch 'main' into EASI-2713/email_notif_on_model_plan_dates_ch…
d14c9e1 
…anged
@ClayBenson94
Added 'copytime' to non-range fields to prevent pointer updates from …
13cdbb1 
…causing issues
@OddTomBrooks
chore: added all fields to date change email output
de879ea
@OddTomBrooks
chore: added all fields to date change email output
9b518c1
@OddTomBrooks
chore: updated unit tests
7314a48
@OddTomBrooks
Merge branch 'main' into EASI-2713/email_notif_on_model_plan_dates_ch…
661991b 
…anged

# Conflicts:
#	pkg/email/model_plan_date_changed.go
#	pkg/email/templates/model_plan_date_changed_body.html
#	pkg/graph/resolvers/plan_basics.go
#	pkg/graph/resolvers/plan_basics_helper.go
#	pkg/graph/resolvers/plan_basics_helper_test.go
@OddTomBrooks OddTomBrooks marked this pull request as ready for review July 25, 2023 16:55
@OddTomBrooks OddTomBrooks requested a review from a team as a code owner July 25, 2023 16:55
@OddTomBrooks OddTomBrooks requested review from ClayBenson94 and removed request for a team July 25, 2023 16:55
@OddTomBrooks OddTomBrooks merged commit 75cc488 into main Aug 1, 2023
8 of 9 checks passed
@OddTomBrooks OddTomBrooks deleted the EASI-2713/email_notif_on_model_plan_dates_changed branch August 1, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClayBenson94 ClayBenson94 ClayBenson94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OddTomBrooks @ClayBenson94