Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINT-3201]/mto ready for review by #1520

Open
wants to merge 11 commits into
base: feature/MINT-3175_mto
Choose a base branch
from

Conversation

StevenWadeOddball
Copy link
Contributor

@StevenWadeOddball StevenWadeOddball commented Nov 14, 2024

MINT-3201

Description

  1. Add ready for review columns to the model plan
  2. Add mutation for toggling ready for review

Also updated the linking table to be correctly reference the user account table

How to test this change

  1. Mark section ready for review by user
  2. Ensure that it marked ready for review and has a time stamp
  3. Change user (through postman variables)
  4. Try to mark ready for review again
  5. Ensure that it didn't change who marked ready for review or the time stamp
  6. Set it as not ready for review
  7. Ensure it no longer is ready for review
  8. Mark ready for review again with the other user
  9. Ensure the time and time stamp was marked

Verify that the unit tests work as expected.

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chatted with @patrickseguraoddball about this today and we might want to consider some other approaches for this that might be a bit more friendly with change history

Functionally, I think this all works just fine and the resolvers/mutations seem to be in the right spots, but it just might be worth considering if we want to break out MTO Data like this into another table that's not on the model plan.

Let's sync up next week, but just leaving this comment so we can discuss further!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants