[EASI-2854] - Part 2 - Beneficiaries, OpsEvalAndLearning Translation …

…Restructure (#661) * Added type for filter groups and updated basics * Completed page one of general characteristics * Updated readonly basics to new name * Fixed misnamed translation * Updated unit tests * Finished page 2 of GC * Finished page 3 of GC * Finished page 3 of GC and add BooleanRadio component and test * Update BooleanRadio test * Added util for mapping with types, added target-and-options * Finished target and options * Finished authority * Fixed incorrect sorting options * Resolved merge conflict and updated snap * Started readonly * Added more snapshot data * Added filtergroups to rest of GC * Added note to basics translation * Added first page of P&P * Added second page of P&P * Finish page 2 of PP * Finish page 3 of PP * Began page 4 of PP * Finished all PP forms and tests * Added filter group mappings * Finished PP readonly * Added better snapshot data * Added better snapshot data * Fixed tests * Updated ops needs questions to still use old translation * Renamed legacy basic translation to basicsOld * Updated snapshots after merge conflicts * Beneficiaries page 1 done * Beneficiaries page 2 done * Beneficiaries page 3 done * Beneficiaries readonly done * Updated readonly ben test data * Page one of OEL done * Page 3 of OEL done * Page 4 of OEL done * Page 5 of OEL done * Began Page 6 of OEL done * Finished page 7 of OEL * Finished page 7part2 of OEL * Finished page 8 of OEL * Finished page 9 of OEL * Finished readonly OEL * Updated tests * Updated readonly mock data * Fixes OEL translation file name for it solutions tracker * Updated cypress tests to use new radio id's * Updated snaps for semiannually * Fixed incorrect merge
CMS-Enterprise · Aug 15, 2023 · d3ecd4a · d3ecd4a
1 parent 505de26
commit d3ecd4a
Show file tree

Hide file tree

Showing 70 changed files with 7,171 additions and 3,381 deletions.
diff --git a/cypress/e2e/characteristics.spec.js b/cypress/e2e/characteristics.spec.js
@@ -19,7 +19,7 @@ describe('The Model Plan General Characteristics Form', () => {
 
     cy.get('[data-testid="model-plan-name"]').contains('for Empty Plan');
 
-    cy.get('#plan-characteristics-is-new-model-no')
+    cy.get('#plan-characteristics-is-new-model-false')
       .check({ force: true })
       .should('be.checked');
 
@@ -29,12 +29,14 @@ describe('The Model Plan General Characteristics Form', () => {
       .type('Plan with B{downArrow}{enter}')
       .should('have.value', 'Plan with Basics');
 
-    cy.get('#plan-characteristics-resembles-existing-model')
+    cy.get('#plan-characteristics-resembles-existing-model-true')
       .check({ force: true })
       .should('be.checked');
 
     cy.get('#plan-characteristics-resembles-which-model').within(() => {
-      cy.get("input[type='text']").type('advance payment{downArrow}{enter}');
+      cy.get("input[type='text']")
+        .click()
+        .type('advance payment{downArrow}{enter}');
     });
 
     cy.get('[data-testid="multiselect-tag--Advance Payment ACO Model"]')
@@ -47,7 +49,7 @@ describe('The Model Plan General Characteristics Form', () => {
       .type('In every way')
       .should('have.value', 'In every way');
 
-    cy.get('#plan-characteristics-has-component-or-tracks')
+    cy.get('#plan-characteristics-has-component-or-tracks-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -89,7 +91,7 @@ describe('The Model Plan General Characteristics Form', () => {
 
     // Page - /characteristics/involvements
 
-    cy.get('#plan-characteristics-care-coordination-involved')
+    cy.get('#plan-characteristics-care-coordination-involved-true')
       .should('not.be.disabled')
       .check({ force: true })
       .should('be.checked');
@@ -98,7 +100,7 @@ describe('The Model Plan General Characteristics Form', () => {
       .type('Yes, care coordination is involved in every way')
       .should('have.value', 'Yes, care coordination is involved in every way');
 
-    cy.get('#plan-characteristics-additional-services')
+    cy.get('#plan-characteristics-additional-services-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -109,7 +111,7 @@ describe('The Model Plan General Characteristics Form', () => {
         'Yes, additional services are involved in every way'
       );
 
-    cy.get('#plan-characteristics-community-partners-involved')
+    cy.get('#plan-characteristics-community-partners-involved-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -124,7 +126,7 @@ describe('The Model Plan General Characteristics Form', () => {
 
     // Page - /characteristics/targets-and-options
 
-    cy.get('#plan-characteristics-geographies-targeted')
+    cy.get('#plan-characteristics-geographies-targeted-true')
       .should('not.be.disabled')
       .check({ force: true })
       .should('be.checked');
@@ -137,7 +139,7 @@ describe('The Model Plan General Characteristics Form', () => {
       .check({ force: true })
       .should('be.checked');
 
-    cy.get('#plan-characteristics-participation')
+    cy.get('#plan-characteristics-participation-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -153,15 +155,15 @@ describe('The Model Plan General Characteristics Form', () => {
       .type('Just a different agreement type')
       .should('have.value', 'Just a different agreement type');
 
-    cy.get('#plan-characteristics-multiple-participation-needed')
+    cy.get('#plan-characteristics-multiple-participation-needed-true')
       .check({ force: true })
       .should('be.checked');
 
     cy.contains('button', 'Next').click();
 
     // Page - /characteristics/authority
 
-    cy.get('#plan-characteristics-rulemaking-required')
+    cy.get('#plan-characteristics-rulemaking-required-true')
       .should('not.be.disabled')
       .check({ force: true })
       .should('be.checked');
@@ -174,7 +176,7 @@ describe('The Model Plan General Characteristics Form', () => {
       .check({ force: true })
       .should('be.checked');
 
-    cy.get('#plan-characteristics-waivers-required')
+    cy.get('#plan-characteristics-waivers-required-true')
       .check({ force: true })
       .should('be.checked');
 

diff --git a/cypress/e2e/modelPlan.spec.js b/cypress/e2e/modelPlan.spec.js
@@ -156,7 +156,10 @@ describe('The Model Plan Form', () => {
       .type('05/23/2025')
       .should('have.value', '05/23/2025');
 
-    cy.get('#phasedIn-Yes').first().check({ force: true }).should('be.checked');
+    cy.get('#phasedIn-true')
+      .first()
+      .check({ force: true })
+      .should('be.checked');
 
     cy.contains('button', 'Save and return to task list').click();
 

diff --git a/cypress/e2e/opsEvalAndLearning.spec.js b/cypress/e2e/opsEvalAndLearning.spec.js
@@ -66,7 +66,7 @@ describe('The Model Plan Ops Eval and Learning Form', () => {
       .type('They will provide wireframes of workflows')
       .should('have.value', 'They will provide wireframes of workflows');
 
-    cy.get('#ops-eval-and-learning-iddoc-support')
+    cy.get('#ops-eval-and-learning-iddoc-support-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -87,7 +87,7 @@ describe('The Model Plan Ops Eval and Learning Form', () => {
     cy.get('@technical-contacts').type('Bill in accounting');
     cy.get('@technical-contacts').should('have.value', 'Bill in accounting');
 
-    cy.get('#ops-eval-and-learning-capture-participant-info')
+    cy.get('#ops-eval-and-learning-capture-participant-info-true')
       .check({ force: true })
       .should('be.checked');
 

diff --git a/cypress/e2e/participantsAndProviders.spec.js b/cypress/e2e/participantsAndProviders.spec.js
@@ -57,7 +57,7 @@ describe('The Model Plan Participants and Providers Form', () => {
       .type('The candy people')
       .should('have.value', 'The candy people');
 
-    cy.get('#participants-and-providers-current-participants')
+    cy.get('#participants-and-providers-current-participants-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -114,7 +114,7 @@ describe('The Model Plan Participants and Providers Form', () => {
       .check({ force: true });
     cy.get('@communication').should('be.checked');
 
-    cy.get('#participants-and-providers-risk')
+    cy.get('#participants-and-providers-risk-true')
       .check({ force: true })
       .should('be.checked');
 
@@ -126,24 +126,24 @@ describe('The Model Plan Participants and Providers Form', () => {
       .type('Programmatic Risk')
       .should('have.value', 'Programmatic Risk');
 
-    cy.get('#participants-and-providers-risk-change')
+    cy.get('#participants-and-providers-risk-change-true')
       .check({ force: true })
       .should('be.checked');
 
     cy.contains('button', 'Next').click();
 
     // Page - /participants-and-providers/coordination
 
-    cy.get('#participants-and-providers-coordniate-work')
+    cy.get('#participants-and-providers-coordniate-work-true')
       .should('not.be.disabled')
       .check({ force: true })
       .should('be.checked');
 
-    cy.get('#participants-and-providers-gainshare-payment')
+    cy.get('#participants-and-providers-gainshare-payment-true')
       .check({ force: true })
       .should('be.checked');
 
-    cy.get('#participants-and-providers-gainshare-track')
+    cy.get('#participants-and-providers-gainshare-track-true')
       .check({ force: true })
       .should('be.checked');
 

diff --git a/src/components/BooleanRadioForm/__snapshots__/index.test.tsx.snap b/src/components/BooleanRadioForm/__snapshots__/index.test.tsx.snap
@@ -12,14 +12,15 @@ exports[`The BooleanRadio component matches snapshot 1`] = `
     >
       <input
         class="usa-radio__input"
-        id="care-coordination-involved"
+        data-testid="care-coordination-involved-true"
+        id="care-coordination-involved-true"
         name="careCoordinationInvolved"
         type="radio"
         value="TRUE"
       />
       <label
         class="usa-radio__label"
-        for="care-coordination-involved"
+        for="care-coordination-involved-true"
       >
         Yes
       </label>
@@ -30,14 +31,15 @@ exports[`The BooleanRadio component matches snapshot 1`] = `
     >
       <input
         class="usa-radio__input"
-        id="care-coordination-involved-no"
+        data-testid="care-coordination-involved-false"
+        id="care-coordination-involved-false"
         name="careCoordinationInvolved"
         type="radio"
         value="FALSE"
       />
       <label
         class="usa-radio__label"
-        for="care-coordination-involved-no"
+        for="care-coordination-involved-false"
       >
         No
       </label>

diff --git a/src/components/BooleanRadioForm/index.tsx b/src/components/BooleanRadioForm/index.tsx
@@ -34,7 +34,8 @@ const BooleanRadio = ({
     <Fieldset className={classNames(className)}>
       <Field
         as={Radio}
-        id={id}
+        id={`${id}-true`}
+        data-testid={`${id}-true`}
         name={fieldName}
         label={options.true}
         value="TRUE"
@@ -51,7 +52,8 @@ const BooleanRadio = ({
 
       <Field
         as={Radio}
-        id={`${id}-no`}
+        id={`${id}-false`}
+        data-testid={`${id}-false`}
         name={fieldName}
         label={options.false}
         value="FALSE"