spawn/Direct: don't close return_cgroup before using it

This fixes a regression by commit e6e4805
CM4all · Nov 21, 2024 · 1a68d7c · 1a68d7c
1 parent 9dc0440
commit 1a68d7c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/spawn/Direct.cxx b/src/spawn/Direct.cxx
@@ -556,9 +556,6 @@ SpawnChildProcess(PreparedChildProcess &&params,
 				}
 			}
 
-			if (params.return_cgroup.IsDefined())
-				params.return_cgroup.Close();
-
 			pid = clone3(&ca, sizeof(ca));
 			if (pid < 0)
 				throw MakeErrno("clone() failed");
@@ -583,6 +580,9 @@ SpawnChildProcess(PreparedChildProcess &&params,
 		}
 	}
 
+	if (params.return_cgroup.IsDefined())
+		params.return_cgroup.Close();
+
 	if (pid == 0) {
 		userns_map_pipe_w.Close();
 		userns_create_pipe_r.Close();