Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 5: Saksham Nagpal #26

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Saksham03
Copy link

@Saksham03 Saksham03 commented Oct 31, 2023

Repo Link
All basic requirements done.
Extra credit: tessellation level based on distance from the camera.
Used my 1 final late day.

Feedback:

  1. This was a really fun project that provided a great learning opportunity and exposure to a new graphics API as well as tessellation & compute shaders!
  2. One week felt a bit less to explore a new graphics API, and the one single lecture we had on Vulkan was mostly a one-way information dump. I think both of these issues can be remediated by doing an interactive lab during the lecture where we do the Vulkan side setup of this project as we follow along the introductory lecture material for Vulkan.
  3. I was (and probably still am, a bit) confused about how the tessellation control shader operated on a single vertex, but the tessellation evaluation shader ran on quad patches. The resources online mostly use triangles or quads as input primitives as well, and therefore a point-based input was confusing to understand myself while learning about the shader as well as the API for the first time. A small recording similar to the debugging lab going over this concept might be helpful.
  4. The denoiser project was very similar to the pathtracer, and therefore I think the final weightage given to this project and the denoiser should be ping-ponged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant