-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project 3: Linda Zhu #31
Open
LinDadaism
wants to merge
27
commits into
CIS565-Fall-2023:main
Choose a base branch
from
LinDadaism:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… need something working urgently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used all 4 late days. Working on REAME now.
Repo link
Features Implemented:
Core Features
Extra Features
Modifications to CMakeLists:
Added the files below for mesh loading to the headers section:
- src/tiny_obj_loader.h
- src/gltf/json.hpp
- src/gltf/tiny_gltf.h
Feedback:
It was definitely a fun project that gives you freedom to explore a plethora of interesting topics in graphics and rendering, or to put focus on CUDA performance optimization. However, it was not even a smooth-sailing experience for me implementing the core features, let alone later debugging the mesh loaders, before I had the chance to do more optimization. I wish we could have had a very basic path tracer provided, say with diffuse shading and an OBJ loader implemented, so that we can spend more time on advanced visual and performance improvements. More importantly, since the focus of this course should really be on GPU programming techniques and CUDA performance optimization, I want to have more practice of using advanced CUDA features such as CUDA stream/ graphs, shared memory, and etc. in this project. Right now my project is not well-balanced, stressing more on impressive graphics without enough thinking on performance. I think that's actually a common pain point of most big class projects, where you try hard to just complete it leaving no time or energy for the better.